100% code coverage (#1011)

Author: fisker

rules/consistent-function-scoping.js

@@ -46,11 +46,13 @@ function checkReferences(scope, parent, scopeManager) {
 		const identifierScope = scopeManager.acquire(identifier);
 
 		// If we have a scope, the earlier checks should have worked so ignore them here
+		/* istanbul ignore next: Hard to test */
 		if (identifierScope) {
 			return false;
 		}
 
 		const identifierParentScope = scopeManager.acquire(identifier.parent);
+		/* istanbul ignore next: Hard to test */
 		if (!identifierParentScope) {
 			return false;
 		}
@@ -119,9 +121,6 @@ function checkNode(node, scopeManager) {
 	}
 
 	let parentNode = node.parent;
-	if (!parentNode) {
-		return true;
-	}
 
 	// Skip over junk like the block statement inside of a function declaration
 	// or the various pieces of an arrow function.

rules/custom-error-definition.js

@@ -161,14 +161,6 @@ const customErrorDefinition = (context, node) => {
 };
 
 const customErrorExport = (context, node) => {
-	if (!node.left.object || node.left.object.name !== 'exports') {
-		return;
-	}
-
-	if (!node.left.property) {
-		return;
-	}
-
 	const exportsName = node.left.property.name;
 
 	const maybeError = node.right;
@@ -203,7 +195,7 @@ const create = context => {
 	return {
 		ClassDeclaration: node => customErrorDefinition(context, node),
 		'AssignmentExpression[right.type="ClassExpression"]': node => customErrorDefinition(context, node.right),
-		'AssignmentExpression[left.type="MemberExpression"]': node => customErrorExport(context, node)
+		'AssignmentExpression[left.type="MemberExpression"][left.object.type="Identifier"][left.object.name="exports"]': node => customErrorExport(context, node)
 	};
 };
 

rules/expiring-todo-comments.js

@@ -187,6 +187,7 @@ function reachedDate(past) {
 }
 
 function tryToCoerceVersion(rawVersion) {
+	/* istanbul ignore if: version in `package.json` and comment can't be empty */
 	if (!rawVersion) {
 		return false;
 	}
@@ -209,10 +210,12 @@ function tryToCoerceVersion(rawVersion) {
 
 	// Get only the first member for cases such as `1.0.0 - 2.9999.9999`
 	const parts = version.split(' ');
+	/* istanbul ignore if: We don't have this `package.json` to test */
 	if (parts.length > 1) {
 		version = parts[0];
 	}
 
+	/* istanbul ignore if: We don't have this `package.json` to test */
 	if (semver.valid(version)) {
 		return version;
 	}
@@ -222,6 +225,7 @@ function tryToCoerceVersion(rawVersion) {
 		// But coerce can't parse pre-releases.
 		return semver.parse(version) || semver.coerce(version);
 	} catch {
+		/* istanbul ignore next: We don't have this `package.json` to test */
 		return false;
 	}
 }
@@ -395,6 +399,7 @@ const create = context => {
 			const todoVersion = tryToCoerceVersion(dependency.version);
 			const targetPackageVersion = tryToCoerceVersion(targetPackageRawVersion);
 
+			/* istanbul ignore if: Can't test in Node.js */
 			if (!hasTargetPackage || !targetPackageVersion) {
 				// Can't compare `¯\_(ツ)_/¯`
 				continue;
@@ -422,6 +427,7 @@ const create = context => {
 			const targetPackageRawEngineVersion = packageEngines.node;
 			const hasTargetEngine = Boolean(targetPackageRawEngineVersion);
 
+			/* istanbul ignore if: Can't test in this repo */
 			if (!hasTargetEngine) {
 				continue;
 			}

rules/no-keyword-prefix.js

@@ -55,6 +55,7 @@ function checkObjectPattern(report, node, options) {
 	const {name, parent} = node;
 	const keyword = findKeywordPrefix(name, options);
 
+	/* istanbul ignore next: Can't find a case to cover this line */
 	if (parent.shorthand && parent.value.left && Boolean(keyword)) {
 		report(node, keyword);
 	}

rules/prefer-query-selector.js

@@ -88,39 +88,36 @@ const hasValue = node => {
 	return true;
 };
 
-const fix = (node, identifierName, preferedSelector) => {
+const fix = (node, identifierName, preferredSelector) => {
 	const nodeToBeFixed = node.arguments[0];
 	if (identifierName === 'getElementsByTagName' || !hasValue(nodeToBeFixed)) {
-		return fixer => fixer.replaceText(node.callee.property, preferedSelector);
+		return fixer => fixer.replaceText(node.callee.property, preferredSelector);
 	}
 
 	const getArgumentFix = nodeToBeFixed.type === 'Literal' ? getLiteralFix : getTemplateLiteralFix;
 	return function * (fixer) {
 		yield * getArgumentFix(fixer, nodeToBeFixed, identifierName);
-		yield fixer.replaceText(node.callee.property, preferedSelector);
+		yield fixer.replaceText(node.callee.property, preferredSelector);
 	};
 };
 
 const create = context => {
 	return {
 		[selector](node) {
 			const method = node.callee.property.name;
-			const preferedSelector = forbiddenIdentifierNames.get(method);
-			if (!preferedSelector) {
-				return;
-			}
+			const preferredSelector = forbiddenIdentifierNames.get(method);
 
 			const problem = {
 				node: node.callee.property,
 				messageId: MESSAGE_ID,
 				data: {
-					replacement: preferedSelector,
+					replacement: preferredSelector,
 					method
 				}
 			};
 
 			if (canBeFixed(node.arguments[0])) {
-				problem.fix = fix(node, method, preferedSelector);
+				problem.fix = fix(node, method, preferredSelector);
 			}
 
 			context.report(problem);

rules/utils/avoid-capture.js

@@ -6,6 +6,7 @@ const indexifyName = (name, index) => name + '_'.repeat(index);
 
 const scopeHasArgumentsSpecial = scope => {
 	while (scope) {
+		/* istanbul ignore next: `someScopeHasVariableName` seems already handle this */
 		if (scope.taints.get('arguments')) {
 			return true;
 		}

test/expiring-todo-comments.js

@@ -119,7 +119,7 @@ test({
 			code: `/*
 			* TODO [2000-01-01]: Yet
 			* TODO [2000-01-01]: Another
-			* TODO [2000-01-01]: Way
+			* TODO [2000-01-01] Way
 			*/`,
 			errors: [
 				expiredTodoError('2000-01-01', 'Yet'),

test/no-for-loop.js

@@ -182,6 +182,15 @@ ruleTester.run('no-for-loop', rule, {
 			for (let i = 0; i < arr.length; i++) {
 				arr[i] = i + 2;
 			}
+		`,
+
+		// Child scope
+		outdent`
+			for (let i = 0; i < cities.length; i++) {
+				const foo = function () {
+					console.log(cities)
+				}
+			}
 		`
 	],
 

test/no-unused-properties.js

@@ -390,6 +390,15 @@ test({
 				console.log(foo.b);
 			`,
 			errors: [error]
+		},
+
+		{
+			code: outdent`
+				const foo = {
+					[foo.bar]: 1
+				};
+			`,
+			errors: [error]
 		}
 	]
 });

test/package.js

@@ -116,4 +116,11 @@ test('Every deprecated rules listed in docs/deprecated-rules.md', t => {
 	const content = fs.readFileSync('docs/deprecated-rules.md', 'utf8');
 	const rulesInMarkdown = content.match(/(?<=^## ).*?$/gm);
 	t.deepEqual(deprecatedRules, rulesInMarkdown);
+
+	for (const name of deprecatedRules) {
+		const rule = index.rules[name];
+		t.is(typeof rule.create, 'function', `${name} create is not function`);
+		t.deepEqual(rule.create(), {}, `${name} create should return empty object`);
+		t.true(rule.meta.deprecated, `${name} meta.deprecated should be true`);
+	}
 });