Fix prevent-abbreviations breaking shorthand properties in assignment patterns (#268)

Author: futpib

rules/prevent-abbreviations.js

@@ -402,9 +402,19 @@ const shouldFix = variable => {
 
 const isShorthandPropertyIdentifier = identifier => {
 	return identifier.parent.type === 'Property' &&
+		identifier.parent.key === identifier &&
 		identifier.parent.shorthand;
 };
 
+const isAssignmentPatternShorthandPropertyIdentifier = identifier => {
+	return identifier.parent.type === 'AssignmentPattern' &&
+		identifier.parent.left === identifier &&
+		identifier.parent.parent.type === 'Property' &&
+		identifier.parent.parent.key === identifier &&
+		identifier.parent.parent.value === identifier.parent &&
+		identifier.parent.parent.shorthand;
+};
+
 const isShorthandImportIdentifier = identifier => {
 	return identifier.parent.type === 'ImportSpecifier' &&
 		identifier.parent.imported.name === identifier.name &&
@@ -418,7 +428,7 @@ const isShorthandExportIdentifier = identifier => {
 };
 
 const fixIdentifier = (fixer, replacement) => identifier => {
-	if (isShorthandPropertyIdentifier(identifier)) {
+	if (isShorthandPropertyIdentifier(identifier) || isAssignmentPatternShorthandPropertyIdentifier(identifier)) {
 		return fixer.replaceText(identifier, `${identifier.name}: ${replacement}`);
 	}
 

test/prevent-abbreviations.js

@@ -580,6 +580,12 @@ ruleTester.run('prevent-abbreviations', rule, {
 			options: customOptions,
 			errors: createErrors()
 		},
+		{
+			code: 'const {err} = foo;',
+			output: 'const {err: error} = foo;',
+			options: customOptions,
+			errors: createErrors()
+		},
 
 		noFixingTestCase({
 			code: 'const foo = {err: 1}',
@@ -890,6 +896,22 @@ ruleTester.run('prevent-abbreviations', rule, {
 				}
 			`,
 			errors: createErrors()
+		},
+
+		{
+			code: `
+				function unicorn(unicorn) {
+					const {docs = {}} = unicorn;
+					return docs;
+				}
+			`,
+			output: `
+				function unicorn(unicorn) {
+					const {docs: documents = {}} = unicorn;
+					return documents;
+				}
+			`,
+			errors: createErrors()
 		}
 	]
 });