no-array-for-each: Fix broken auto-fixed code (#1039)

Author: fisker

rules/no-array-for-each.js

@@ -49,11 +49,11 @@ function getFixFunction(callExpression, sourceCode, functionInfo) {
 	const {returnStatements} = functionInfo.get(callback);
 
 	const getForOfLoopHeadText = () => {
-		const parametersText = parameters.map(parameter => sourceCode.getText(parameter));
+		const [elementText, indexText] = parameters.map(parameter => sourceCode.getText(parameter));
 		const useEntries = parameters.length === 2;
 
 		let text = 'for (const ';
-		text += useEntries ? `[${parametersText.join(', ')}]` : parametersText[0];
+		text += useEntries ? `[${indexText}, ${elementText}]` : elementText;
 
 		text += ' of ';
 
@@ -351,7 +351,7 @@ const create = context => {
 		},
 		ReturnStatement(node) {
 			const currentFunction = functionStack[functionStack.length - 1];
-			// `globalReturn `
+			// `globalReturn`
 			/* istanbul ignore next: ESLint deprecated `ecmaFeatures`, can't test */
 			if (!currentFunction) {
 				return;

test/snapshots/no-array-for-each.js.md

@@ -397,7 +397,7 @@ Generated by [AVA](https://avajs.dev).
 > Output
 
     `␊
-      1 | for (const [foo, index] of a((foo, index) => foo + index).entries())  bar();␊
+      1 | for (const [index, foo] of a((foo, index) => foo + index).entries())  bar();␊
     `
 
 > Error 1/1
@@ -417,7 +417,7 @@ Generated by [AVA](https://avajs.dev).
     `␊
       1 | const foo = [];␊
       2 | const index = 1;␊
-      3 | for (const [foo, index] of a.entries())  foo[index];␊
+      3 | for (const [index, foo] of a.entries())  foo[index];␊
     `
 
 > Error 1/1
@@ -763,7 +763,7 @@ Generated by [AVA](https://avajs.dev).
 > Output
 
     `␊
-      1 | for (const [element, index] of foo.entries()) {␊
+      1 | for (const [index, element] of foo.entries()) {␊
       2 | 	bar(element, index);␊
       3 | }␊
     `
@@ -785,7 +785,7 @@ Generated by [AVA](https://avajs.dev).
 > Output
 
     `␊
-      1 | for (const [element, index] of foo.entries()) {␊
+      1 | for (const [index, element] of foo.entries()) {␊
       2 | 	bar(element, index);␊
       3 | }␊
     `
@@ -807,7 +807,7 @@ Generated by [AVA](https://avajs.dev).
 > Output
 
     `␊
-      1 | for (const [element, index] of foo.entries()) {␊
+      1 | for (const [index, element] of foo.entries()) {␊
       2 | 	bar(element, index);␊
       3 | }␊
     `
@@ -827,7 +827,7 @@ Generated by [AVA](https://avajs.dev).
 > Output
 
     `␊
-      1 | for (const [element, index] of foo.entries())  bar(element, index);␊
+      1 | for (const [index, element] of foo.entries())  bar(element, index);␊
     `
 
 > Error 1/1
@@ -843,7 +843,7 @@ Generated by [AVA](https://avajs.dev).
 > Output
 
     `␊
-      1 | for (const [element, index] of (foo).entries())  bar(element, index)␊
+      1 | for (const [index, element] of (foo).entries())  bar(element, index)␊
     `
 
 > Error 1/1
@@ -859,7 +859,7 @@ Generated by [AVA](https://avajs.dev).
 > Output
 
     `␊
-      1 | for (const [element, index] of (0, foo).entries())  bar(element, index)␊
+      1 | for (const [index, element] of (0, foo).entries())  bar(element, index)␊
     `
 
 > Error 1/1