Update ESLint to v7 (#577)

Author: fisker

package.json

@@ -53,7 +53,7 @@
 		"ava": "^3.8.1",
 		"babel-eslint": "^10.1.0",
 		"chalk": "^4.0.0",
-		"eslint": "^6.8.0",
+		"eslint": "^7.0.0",
 		"eslint-ava-rule-tester": "^4.0.0",
 		"eslint-plugin-eslint-plugin": "^2.2.1",
 		"execa": "^4.0.0",
@@ -66,7 +66,7 @@
 		"xo": "^0.30.0"
 	},
 	"peerDependencies": {
-		"eslint": ">=6.8.0"
+		"eslint": ">=7.0.0"
 	},
 	"ava": {
 		"babel": true,

test/better-regex.js

@@ -10,7 +10,6 @@ const ruleTester = avaRuleTester(test, {
 
 const createError = (original, optimized) => [
 	{
-		ruleId: 'better-regex',
 		message: `${original} can be optimized to ${optimized}`
 	}
 ];

test/consistent-function-scoping.js

@@ -17,12 +17,10 @@ const typescriptRuleTester = avaRuleTester(test, {
 	parser: require.resolve('@typescript-eslint/parser')
 });
 
-const ruleId = 'consistent-function-scoping';
 const MESSAGE_ID_NAMED = 'named';
 const MESSAGE_ID_ANONYMOUS = 'anonymous';
 
 const createError = ({name, arrow}) => ({
-	ruleId,
 	messageId: name ? MESSAGE_ID_NAMED : MESSAGE_ID_ANONYMOUS,
 	data: {
 		functionType: arrow ? 'arrow function' : 'function',

test/custom-error-definition.js

@@ -18,13 +18,12 @@ const typescriptRuleTester = avaRuleTester(test, {
 	parser: require.resolve('@typescript-eslint/parser')
 });
 
-const invalidClassNameError = {ruleId: 'custom-error-definition', message: 'Invalid class name, use `FooError`.'};
-const constructorError = {ruleId: 'custom-error-definition', message: 'Add a constructor to your error.'};
-const noSuperCallError = {ruleId: 'custom-error-definition', message: 'Missing call to `super()` in constructor.'};
-const invalidNameError = name => ({ruleId: 'custom-error-definition', message: `The \`name\` property should be set to \`${name}\`.`});
-const passMessageToSuperError = {ruleId: 'custom-error-definition', message: 'Pass the error message to `super()` instead of setting `this.message`.'};
+const invalidClassNameError = {message: 'Invalid class name, use `FooError`.'};
+const constructorError = {message: 'Add a constructor to your error.'};
+const noSuperCallError = {message: 'Missing call to `super()` in constructor.'};
+const invalidNameError = name => ({message: `The \`name\` property should be set to \`${name}\`.`});
+const passMessageToSuperError = {message: 'Pass the error message to `super()` instead of setting `this.message`.'};
 const invalidExportError = {
-	ruleId: 'custom-error-definition',
 	messageId: 'invalidExport'
 };
 

test/error-message.js

@@ -10,12 +10,10 @@ const ruleTester = avaRuleTester(test, {
 });
 
 const emptyStringError = {
-	ruleId: 'error-message',
 	message: 'Error message should not be an empty string.'
 };
 
 const noMessageError = {
-	ruleId: 'error-message',
 	message: 'Pass a message to the error constructor.'
 };
 

test/escape-case.js

@@ -11,7 +11,6 @@ const ruleTester = avaRuleTester(test, {
 
 const errors = [
 	{
-		ruleId: 'escape-case',
 		message: 'Use uppercase characters for the value of the escape sequence.'
 	}
 ];

test/expiring-todo-comments.js

@@ -9,57 +9,46 @@ const ruleTester = avaRuleTester(test, {
 });
 
 const expiredTodoError = (expirationDate, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `There is a TODO that is past due date: ${expirationDate}. ${message}`
 });
 
 const avoidMultipleDatesError = (expirationDates, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `Avoid using multiple expiration dates in TODO: ${expirationDates}. ${message}`
 });
 
 const havePackageError = (package_, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `There is a TODO that is deprecated since you installed: ${package_}. ${message}`
 });
 
 const dontHavePackageError = (package_, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `There is a TODO that is deprecated since you uninstalled: ${package_}. ${message}`
 });
 
 const versionMatchesError = (comparison, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `There is a TODO match for package version: ${comparison}. ${message}`
 });
 
 const engineMatchesError = (comparison, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `There is a TODO match for Node.js version: ${comparison}. ${message}`
 });
 
 const reachedPackageVersionError = (version, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `There is a TODO that is past due package version: ${version}. ${message}`
 });
 
 const avoidMultiplePackageVersionsError = (versions, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `Avoid using multiple package versions in TODO: ${versions}. ${message}`
 });
 
 const removeWhitespacesError = (argument, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `Avoid using whitespaces on TODO argument. On '${argument}' use '${argument.replace(/ /g, '')}'. ${message}`
 });
 
 const missingAtSymbolError = (bad, good, message) => ({
-	ruleId: 'expiring-todo-comments',
 	message: `Missing '@' on TODO argument. On '${bad}' use '${good}'. ${message}`
 });
 
 const noWarningCommentError = () => ({
-	ruleId: 'expiring-todo-comments',
 	message: 'Unexpected \'todo\' comment.'
 });
 

test/explicit-length-check.js

@@ -10,7 +10,6 @@ const ruleTester = avaRuleTester(test, {
 
 const error = message => {
 	return {
-		ruleId: 'explicit-length-check',
 		message
 	};
 };

test/filename-case.js

@@ -31,7 +31,6 @@ function testCaseWithOptions(filename, errorMessage, options = []) {
 		options,
 		errors: errorMessage && [
 			{
-				ruleId: 'filename-case',
 				message: errorMessage
 			}
 		]

test/import-index.js

@@ -12,7 +12,6 @@ const ruleTester = avaRuleTester(test, {
 });
 
 const error = {
-	ruleId: 'import-index',
 	message: 'Do not reference the index file directly.'
 };