Replace .range with sourceCode.getRange() (#2553)

Author: fisker

rules/consistent-existence-index-check.js

@@ -96,9 +96,12 @@ const create = context => ({
 				token => token.type === 'Punctuator' && token.value === operator,
 			);
 
+			const [start] = sourceCode.getRange(operatorToken);
+			const [, end] = sourceCode.getRange(right);
+
 			yield {
 				node: binaryExpression,
-				loc: toLocation([operatorToken.range[0], right.range[1]], sourceCode),
+				loc: toLocation([start, end], sourceCode),
 				messageId: MESSAGE_ID,
 				data: {
 					...replacement,

rules/custom-error-definition.js

@@ -77,7 +77,9 @@ function * customErrorDefinition(context, node) {
 		};
 	}
 
-	const {body, range} = node.body;
+	const {sourceCode} = context;
+	const {body} = node.body;
+	const range = sourceCode.getRange(node.body);
 	const constructor = body.find(x => x.kind === 'constructor');
 
 	if (!constructor) {
@@ -118,16 +120,15 @@ function * customErrorDefinition(context, node) {
 			* fix(fixer) {
 				if (superExpression.expression.arguments.length === 0) {
 					const rhs = expression.expression.right;
-					yield fixer.insertTextAfterRange([
-						superExpression.range[0],
-						superExpression.range[0] + 6,
-					], rhs.raw || rhs.name);
+					const [start] = sourceCode.getRange(superExpression);
+					yield fixer.insertTextAfterRange([start, start + 6], rhs.raw || rhs.name);
 				}
 
-				yield fixer.removeRange([
-					messageExpressionIndex === 0 ? constructorBodyNode.range[0] : constructorBody[messageExpressionIndex - 1].range[1],
-					expression.range[1],
-				]);
+				const start = messageExpressionIndex === 0
+					? sourceCode.getRange(constructorBodyNode)[0]
+					: sourceCode.getRange(constructorBody[messageExpressionIndex - 1])[1];
+				const [, end] = sourceCode.getRange(expression);
+				yield fixer.removeRange([start, end]);
 			},
 		};
 	}

rules/empty-brace-spaces.js

@@ -12,8 +12,8 @@ const getProblem = (node, context) => {
 		: isOpeningBraceToken;
 	const openingBrace = sourceCode.getFirstToken(node, {filter});
 	const closingBrace = sourceCode.getLastToken(node);
-	const [, start] = openingBrace.range;
-	const [end] = closingBrace.range;
+	const [, start] = sourceCode.getRange(openingBrace);
+	const [end] = sourceCode.getRange(closingBrace);
 	const textBetween = sourceCode.text.slice(start, end);
 
 	if (!/^\s+$/.test(textBetween)) {

rules/fix/remove-argument.js

@@ -8,19 +8,20 @@ export default function removeArgument(fixer, node, sourceCode) {
 	const firstToken = parentheses[0] || node;
 	const lastToken = parentheses.at(-1) || node;
 
-	let [start] = firstToken.range;
-	let [, end] = lastToken.range;
+	let [start] = sourceCode.getRange(firstToken);
+	let [, end] = sourceCode.getRange(lastToken);
 
 	if (index !== 0) {
-		start = sourceCode.getTokenBefore(firstToken).range[0];
+		const commaToken = sourceCode.getTokenBefore(firstToken);
+		[start] = sourceCode.getRange(commaToken);
 	}
 
 	// If the removed argument is the only argument, the trailing comma must be removed too
 	/* c8 ignore start */
 	if (callExpression.arguments.length === 1) {
 		const tokenAfter = sourceCode.getTokenBefore(lastToken);
 		if (isCommaToken(tokenAfter)) {
-			end = tokenAfter[1];
+			[, end] = sourceCode.getRange(tokenAfter);
 		}
 	}
 	/* c8 ignore end */

rules/fix/remove-member-expression-property.js

@@ -2,6 +2,6 @@ import {getParenthesizedRange} from '../utils/parentheses.js';
 
 export default function removeMemberExpressionProperty(fixer, memberExpression, sourceCode) {
 	const [, start] = getParenthesizedRange(memberExpression.object, sourceCode);
-	const [, end] = memberExpression.range;
+	const [, end] = sourceCode.getRange(memberExpression);
 	return fixer.removeRange([start, end]);
 }

rules/fix/remove-method-call.js

@@ -11,7 +11,7 @@ export default function * removeMethodCall(fixer, callExpression, sourceCode) {
 	// `(( (( foo )).bar ))()`
 	//                     ^^
 	const [, start] = getParenthesizedRange(memberExpression, sourceCode);
-	const [, end] = callExpression.range;
+	const [, end] = sourceCode.getRange(callExpression);
 
 	yield fixer.removeRange([start, end]);
 }

rules/fix/remove-specifier.js

@@ -17,12 +17,12 @@ export default function * removeSpecifier(specifier, fixer, sourceCode, keepDecl
 
 				const hasDefaultImport = specifiers.some(node => node.type === 'ImportDefaultSpecifier');
 				const startToken = sourceCode.getTokenBefore(specifier, hasDefaultImport ? isCommaToken : isOpeningBraceToken);
+				const [start] = sourceCode.getRange(startToken);
+				const [end] = sourceCode.getRange(fromToken);
 				const tokenBefore = sourceCode.getTokenBefore(startToken);
+				const shouldInsertSpace = sourceCode.getRange(tokenBefore)[1] === start;
 
-				yield fixer.replaceTextRange(
-					[startToken.range[0], fromToken.range[0]],
-					tokenBefore.range[1] === startToken.range[0] ? ' ' : '',
-				);
+				yield fixer.replaceTextRange([start, end], shouldInsertSpace ? ' ' : '');
 				return;
 			}
 			// Fallthrough

rules/fix/replace-node-or-token-and-spaces-before.js

@@ -7,7 +7,7 @@ export default function * replaceNodeOrTokenAndSpacesBefore(nodeOrToken, replace
 		yield * replaceNodeOrTokenAndSpacesBefore(token, '', fixer, sourceCode, tokenStore);
 	}
 
-	let [start, end] = nodeOrToken.range;
+	let [start, end] = sourceCode.getRange(nodeOrToken);
 
 	const textBefore = sourceCode.text.slice(0, start);
 	const [trailingSpaces] = textBefore.match(/\s*$/);

rules/no-anonymous-default-export.js

@@ -64,17 +64,20 @@ function addName(fixer, node, name, sourceCode) {
 				node,
 				isOpeningParenToken,
 			);
+			const characterBefore = sourceCode.text.charAt(sourceCode.getRange(openingParenthesisToken)[0] - 1);
 			return fixer.insertTextBefore(
 				openingParenthesisToken,
-				`${sourceCode.text.charAt(openingParenthesisToken.range[0] - 1) === ' ' ? '' : ' '}${name} `,
+				`${characterBefore === ' ' ? '' : ' '}${name} `,
 			);
 		}
 
 		case 'ArrowFunctionExpression': {
 			const [exportDeclarationStart, exportDeclarationEnd]
-				= node.parent.type === 'ExportDefaultDeclaration'
-					? node.parent.range
-					: node.parent.parent.range;
+				= sourceCode.getRange(
+					node.parent.type === 'ExportDefaultDeclaration'
+						? node.parent
+						: node.parent.parent,
+				);
 			const [arrowFunctionStart, arrowFunctionEnd] = getParenthesizedRange(node, sourceCode);
 
 			let textBefore = sourceCode.text.slice(exportDeclarationStart, arrowFunctionStart);

rules/no-array-for-each.js

@@ -120,7 +120,7 @@ function getFixFunction(callExpression, functionInfo, context) {
 	};
 
 	const getForOfLoopHeadRange = () => {
-		const [start] = callExpression.range;
+		const [start] = sourceCode.getRange(callExpression);
 		const [end] = getParenthesizedRange(callback.body, sourceCode);
 		return [start, end];
 	};
@@ -262,7 +262,7 @@ function getFixFunction(callExpression, functionInfo, context) {
 		}
 
 		// Prevent possible variable conflicts
-		yield * extendFixRange(fixer, callExpression.parent.range);
+		yield * extendFixRange(fixer, sourceCode.getRange(callExpression.parent));
 	};
 }
 
@@ -290,9 +290,10 @@ function isFunctionParametersSafeToFix(callbackFunction, {sourceCode, scope, cal
 		}
 
 		const variableName = definition.name.name;
-		const [callExpressionStart, callExpressionEnd] = callExpression.range;
+		const [callExpressionStart, callExpressionEnd] = sourceCode.getRange(callExpression);
 		for (const identifier of allIdentifiers) {
-			const {name, range: [start, end]} = identifier;
+			const {name} = identifier;
+			const [start, end] = sourceCode.getRange(identifier);
 			if (
 				name !== variableName
 				|| start < callExpressionStart