Update ESLint and use the new isGlobalReference to make rule stricter (#2682)

Author: fisker

package.json

@@ -58,7 +58,7 @@
 	"dependencies": {
 		"@babel/helper-validator-identifier": "^7.27.1",
 		"@eslint-community/eslint-utils": "^4.7.0",
-		"@eslint/plugin-kit": "^0.3.1",
+		"@eslint/plugin-kit": "^0.3.2",
 		"change-case": "^5.4.4",
 		"ci-info": "^4.2.0",
 		"clean-regexp": "^1.0.0",
@@ -85,7 +85,7 @@
 		"ava": "^6.4.0",
 		"c8": "^10.1.3",
 		"enquirer": "^2.4.1",
-		"eslint": "^9.28.0",
+		"eslint": "^9.29.0",
 		"eslint-ava-rule-tester": "^5.0.1",
 		"eslint-config-xo": "^0.47.0",
 		"eslint-doc-generator": "^2.1.2",
@@ -110,7 +110,7 @@
 		"yaml": "^2.8.0"
 	},
 	"peerDependencies": {
-		"eslint": ">=9.28.0"
+		"eslint": ">=9.29.0"
 	},
 	"ava": {
 		"files": [

rules/no-useless-error-capture-stack-trace.js

@@ -10,12 +10,11 @@ const messages = {
 	[MESSAGE_ID_ERROR]: 'Unnecessary `Error.captureStackTrace(…)` call.',
 };
 
-// TODO: Make sure the super class is global
-// https://github.com/eslint/eslint/pull/19695
-const isSubclassOfBuiltinErrors = node =>
+const isSubclassOfBuiltinErrors = (node, context) =>
 	node?.superClass
 	&& node.superClass.type === 'Identifier'
-	&& builtinErrors.includes(node.superClass.name);
+	&& builtinErrors.includes(node.superClass.name)
+	&& context.sourceCode.isGlobalReference(node.superClass);
 
 const isClassReference = (node, classNode, context) => {
 	// `new.target`
@@ -88,15 +87,15 @@ const create = context => {
 		const errorClass = classStack.at(-1);
 
 		if (!(
-			isSubclassOfBuiltinErrors(errorClass)
+			isSubclassOfBuiltinErrors(errorClass, context)
 			&& isClassConstructor(thisScopeStack.at(-1), errorClass)
 			&& isMethodCall(callExpression, {
 				object: 'Error',
 				method: 'captureStackTrace',
 				argumentsLength: 2,
 				optionalMember: false,
 			})
-			// TODO: Make sure the `object` is global
+			&& context.sourceCode.isGlobalReference(callExpression.callee.object)
 		)) {
 			return;
 		}

rules/shared/builtin-errors.js

@@ -7,7 +7,6 @@ const builtinErrors = [
 	'SyntaxError',
 	'TypeError',
 	'URIError',
-	'InternalError',
 	'AggregateError',
 	'SuppressedError',
 ];

test/no-instanceof-builtins.js

@@ -23,7 +23,6 @@ const strictStrategyInvalid = [
 	'foo instanceof SyntaxError',
 	'foo instanceof TypeError',
 	'foo instanceof URIError',
-	'foo instanceof InternalError',
 	'foo instanceof AggregateError',
 	'foo instanceof SuppressedError',
 
@@ -101,7 +100,6 @@ test.snapshot({
 		'err instanceof SyntaxError',
 		'err instanceof TypeError',
 		'err instanceof URIError',
-		'err instanceof InternalError',
 		'err instanceof AggregateError',
 		'err instanceof SuppressedError',
 	].map(code => ({code, options: [{useErrorIsError: true, strategy: 'strict'}]})),

test/no-useless-error-capture-stack-trace.js

@@ -83,6 +83,22 @@ test.snapshot({
 				}
 			}
 		`,
+		outdent`
+			class Error {}
+			class MyError extends Error {
+				constructor() {
+					Error.captureStackTrace(this, MyError)
+				}
+			}
+		`,
+		outdent`
+			class Error {}
+			class MyError extends RangeError {
+				constructor() {
+					Error.captureStackTrace(this, MyError)
+				}
+			}
+		`,
 	],
 	invalid: [
 		...[
@@ -154,24 +170,6 @@ test.snapshot({
 				}
 			)
 		`,
-		// This will be fixed when we add global reference check
-		outdent`
-			const Error = () => {}
-			class MyError extends Error {
-				constructor() {
-					Error.captureStackTrace(this, MyError)
-				}
-			}
-		`,
-		// This will be fixed when we add global reference check
-		outdent`
-			const Error = () => {}
-			class MyError extends RangeError {
-				constructor() {
-					Error.captureStackTrace(this, MyError)
-				}
-			}
-		`,
 	],
 });