Do not use module.parent for resolving rule name (#161)

sudo-suhas · sindresorhus · commit f41abbb80996 · 2018-02-16T11:13:01.000+07:00
`module.parent` is cached after the first `require` and this results in nearly
all rules having the URL to `assertion-arguments`.
diff --git a/rules/catch-error-name.js b/rules/catch-error-name.js
@@ -115,7 +115,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		schema
 	}
diff --git a/rules/custom-error-definition.js b/rules/custom-error-definition.js
@@ -132,7 +132,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/error-message.js b/rules/error-message.js
@@ -91,7 +91,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		}
 	}
 };
diff --git a/rules/escape-case.js b/rules/escape-case.js
@@ -56,7 +56,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/explicit-length-check.js b/rules/explicit-length-check.js
@@ -154,7 +154,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code',
 		schema
diff --git a/rules/filename-case.js b/rules/filename-case.js
@@ -116,7 +116,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		schema
 	}
diff --git a/rules/import-index.js b/rules/import-index.js
@@ -26,7 +26,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/new-for-builtins.js b/rules/new-for-builtins.js
@@ -67,7 +67,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/no-abusive-eslint-disable.js b/rules/no-abusive-eslint-disable.js
@@ -32,7 +32,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		}
 	}
 };
diff --git a/rules/no-array-instanceof.js b/rules/no-array-instanceof.js
@@ -20,7 +20,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/no-fn-reference-in-iterator.js b/rules/no-fn-reference-in-iterator.js
@@ -49,7 +49,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/no-hex-escape.js b/rules/no-hex-escape.js
@@ -29,7 +29,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/no-new-buffer.js b/rules/no-new-buffer.js
@@ -25,7 +25,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/no-process-exit.js b/rules/no-process-exit.js
@@ -40,7 +40,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		}
 	}
 };
diff --git a/rules/no-unsafe-regex.js b/rules/no-unsafe-regex.js
@@ -53,7 +53,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		}
 	}
 };
diff --git a/rules/number-literal-case.js b/rules/number-literal-case.js
@@ -33,7 +33,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/prefer-add-event-listener.js b/rules/prefer-add-event-listener.js
@@ -45,7 +45,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/prefer-spread.js b/rules/prefer-spread.js
@@ -51,7 +51,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/prefer-starts-ends-with.js b/rules/prefer-starts-ends-with.js
@@ -53,7 +53,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		}
 	}
 };
diff --git a/rules/prefer-type-error.js b/rules/prefer-type-error.js
@@ -120,7 +120,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/regex-shorthand.js b/rules/regex-shorthand.js
@@ -62,7 +62,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/throw-new-error.js b/rules/throw-new-error.js
@@ -22,7 +22,7 @@ module.exports = {
 	create,
 	meta: {
 		docs: {
-			url: getDocsUrl()
+			url: getDocsUrl(__filename)
 		},
 		fixable: 'code'
 	}
diff --git a/rules/utils/get-docs-url.js b/rules/utils/get-docs-url.js
@@ -4,7 +4,7 @@ const pkg = require('../../package');
 
 const repoUrl = 'https://github.com/sindresorhus/eslint-plugin-unicorn';
 
-module.exports = ruleName => {
-	ruleName = ruleName || path.basename(module.parent.filename, '.js');
+module.exports = filename => {
+	const ruleName = path.basename(filename, '.js');
 	return `${repoUrl}/blob/v${pkg.version}/docs/rules/${ruleName}.md`;
 };
diff --git a/test/get-docs-url.js b/test/get-docs-url.js
@@ -4,10 +4,10 @@ import getDocsUrl from '../rules/utils/get-docs-url';
 
 test('returns the URL of the a named rule\'s documentation', t => {
 	const url = `https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v${pkg.version}/docs/rules/foo.md`;
-	t.is(getDocsUrl('foo'), url);
+	t.is(getDocsUrl('foo.js'), url);
 });
 
 test('determines the rule name from the file', t => {
 	const url = `https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v${pkg.version}/docs/rules/get-docs-url.md`;
-	t.is(getDocsUrl(), url);
+	t.is(getDocsUrl(__filename), url);
 });

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ module.exports = {`
`115`	`115`	`create,`
`116`	`116`	`meta: {`
`117`	`117`	`docs: {`
`118`		`- url: getDocsUrl()`
	`118`	`+ url: getDocsUrl(__filename)`
`119`	`119`	`},`
`120`	`120`	`schema`
`121`	`121`	`}`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ module.exports = {`
`132`	`132`	`create,`
`133`	`133`	`meta: {`
`134`	`134`	`docs: {`
`135`		`- url: getDocsUrl()`
	`135`	`+ url: getDocsUrl(__filename)`
`136`	`136`	`},`
`137`	`137`	`fixable: 'code'`
`138`	`138`	`}`
Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ module.exports = {`
`91`	`91`	`create,`
`92`	`92`	`meta: {`
`93`	`93`	`docs: {`
`94`		`- url: getDocsUrl()`
	`94`	`+ url: getDocsUrl(__filename)`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`	`};`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ module.exports = {`
`56`	`56`	`create,`
`57`	`57`	`meta: {`
`58`	`58`	`docs: {`
`59`		`- url: getDocsUrl()`
	`59`	`+ url: getDocsUrl(__filename)`
`60`	`60`	`},`
`61`	`61`	`fixable: 'code'`
`62`	`62`	`}`
Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ module.exports = {`
`116`	`116`	`create,`
`117`	`117`	`meta: {`
`118`	`118`	`docs: {`
`119`		`- url: getDocsUrl()`
	`119`	`+ url: getDocsUrl(__filename)`
`120`	`120`	`},`
`121`	`121`	`schema`
`122`	`122`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ module.exports = {`
`26`	`26`	`create,`
`27`	`27`	`meta: {`
`28`	`28`	`docs: {`
`29`		`- url: getDocsUrl()`
	`29`	`+ url: getDocsUrl(__filename)`
`30`	`30`	`},`
`31`	`31`	`fixable: 'code'`
`32`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ module.exports = {`
`67`	`67`	`create,`
`68`	`68`	`meta: {`
`69`	`69`	`docs: {`
`70`		`- url: getDocsUrl()`
	`70`	`+ url: getDocsUrl(__filename)`
`71`	`71`	`},`
`72`	`72`	`fixable: 'code'`
`73`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ module.exports = {`
`32`	`32`	`create,`
`33`	`33`	`meta: {`
`34`	`34`	`docs: {`
`35`		`- url: getDocsUrl()`
	`35`	`+ url: getDocsUrl(__filename)`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`	`};`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ module.exports = {`
`20`	`20`	`create,`
`21`	`21`	`meta: {`
`22`	`22`	`docs: {`
`23`		`- url: getDocsUrl()`
	`23`	`+ url: getDocsUrl(__filename)`
`24`	`24`	`},`
`25`	`25`	`fixable: 'code'`
`26`	`26`	`}`