Refactor: remove eslint-ast-utils package (#1048)

Co-authored-by: Sindre Sorhus <[email protected]>

Author: fisker

package.json

@@ -37,7 +37,6 @@
 	"dependencies": {
 		"ci-info": "^2.0.0",
 		"clean-regexp": "^1.0.0",
-		"eslint-ast-utils": "^1.1.0",
 		"eslint-template-visitor": "^2.2.2",
 		"eslint-utils": "^2.1.0",
 		"import-modules": "^2.1.0",

rules/prefer-reflect-apply.js

@@ -1,7 +1,7 @@
 'use strict';
-const astUtils = require('eslint-ast-utils');
 const getDocumentationUrl = require('./utils/get-documentation-url');
 const isLiteralValue = require('./utils/is-literal-value');
+const getPropertyName = require('./utils/get-property-name');
 
 const MESSAGE_ID = 'prefer-reflect-apply';
 const messages = {
@@ -26,7 +26,7 @@ const getReflectApplyCall = (sourceCode, target, receiver, argumentsList) => (
 
 const fixDirectApplyCall = (node, sourceCode) => {
 	if (
-		astUtils.getPropertyName(node.callee) === 'apply' &&
+		getPropertyName(node.callee) === 'apply' &&
 		node.arguments.length === 2 &&
 		isApplySignature(node.arguments[0], node.arguments[1])
 	) {
@@ -41,9 +41,9 @@ const fixDirectApplyCall = (node, sourceCode) => {
 
 const fixFunctionPrototypeCall = (node, sourceCode) => {
 	if (
-		astUtils.getPropertyName(node.callee) === 'call' &&
-		astUtils.getPropertyName(node.callee.object) === 'apply' &&
-		astUtils.getPropertyName(node.callee.object.object) === 'prototype' &&
+		getPropertyName(node.callee) === 'call' &&
+		getPropertyName(node.callee.object) === 'apply' &&
+		getPropertyName(node.callee.object.object) === 'prototype' &&
 		node.callee.object.object.object &&
 		node.callee.object.object.object.type === 'Identifier' &&
 		node.callee.object.object.object.name === 'Function' &&

rules/prevent-abbreviations.js

@@ -1,6 +1,5 @@
 'use strict';
 const path = require('path');
-const astUtils = require('eslint-ast-utils');
 const {defaultsDeep, upperFirst, lowerFirst} = require('lodash');
 
 const getDocumentationUrl = require('./utils/get-documentation-url');
@@ -432,6 +431,16 @@ const shouldFix = variable => {
 	return !getVariableIdentifiers(variable).some(identifier => isExportedIdentifier(identifier));
 };
 
+const isStaticRequire = node => Boolean(
+	node &&
+	node.callee &&
+	node.callee.type === 'Identifier' &&
+	node.callee.name === 'require' &&
+	node.arguments.length === 1 &&
+	node.arguments[0].type === 'Literal' &&
+	typeof node.arguments[0].value === 'string'
+);
+
 const isDefaultOrNamespaceImportName = identifier => {
 	if (
 		identifier.parent.type === 'ImportDefaultSpecifier' &&
@@ -459,7 +468,7 @@ const isDefaultOrNamespaceImportName = identifier => {
 	if (
 		identifier.parent.type === 'VariableDeclarator' &&
 		identifier.parent.id === identifier &&
-		astUtils.isStaticRequire(identifier.parent.init)
+		isStaticRequire(identifier.parent.init)
 	) {
 		return true;
 	}

rules/utils/get-property-name.js

@@ -0,0 +1,30 @@
+'use strict';
+const {getStaticValue} = require('eslint-utils');
+
+/**
+Get the property value of a `MemberExpression` node.
+
+@param {Node} node - The `MemberExpression` node.
+@param {Scope} [scope] - The scope to start finding the variable. Optional. If this scope was given, it tries to resolve identifier references which are in the given node as much as possible.
+*/
+function getPropertyName(node, scope) {
+	const {type, property, computed} = node;
+	/* istanbul ignore next */
+	if (type !== 'MemberExpression') {
+		return;
+	}
+
+	if (!computed) {
+		if (property.type === 'Identifier') {
+			return property.name;
+		}
+
+		/* istanbul ignore next: It could be `PrivateIdentifier`(ESTree) or `PrivateName`(Babel) when it's in `class` */
+		return;
+	}
+
+	const result = getStaticValue(property, scope);
+	return result && result.value;
+}
+
+module.exports = getPropertyName;

test/prefer-reflect-apply.js

@@ -22,7 +22,9 @@ test({
 		'foo.apply;',
 		'apply;',
 		'Reflect.apply(foo, null);',
-		'Reflect.apply(foo, null, [bar]);'
+		'Reflect.apply(foo, null, [bar]);',
+		// Currently, we are not passing `scope` to `getStaticValue`, so the method is unknown
+		'const apply = "apply"; foo[apply](null, [42]);'
 	],
 	invalid: [
 		{
@@ -74,6 +76,11 @@ test({
 			code: 'Function.prototype.apply.call(foo, this, arguments);',
 			output: 'Reflect.apply(foo, this, arguments);',
 			errors
+		},
+		{
+			code: 'foo["apply"](null, [42]);',
+			output: 'Reflect.apply(foo, null, [42]);',
+			errors
 		}
 	]
 });