Skip to content

feat: add 'unopinionated' config #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add 'unopinionated' config #2715

wants to merge 2 commits into from
+415 −381

Conversation

JoshuaKGoldberg
Copy link

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 7, 2025 •
edited
Loading

Fixes #896.

Adds all rules from recommended to a new unopinionated config, with the exception of rules that add in subjective opinions >1% of users might not want (per my vague guesstimation). This list was generated by looking through #896 & linked issues, then running on my personal repos:

Rule Reason Mentioned
catch-error-name Subjective naming preference #896
consistent-function-scoping Subjective preference; doesn't impact control flow
empty-brace-spaces Formatters also handle this #2634
explicit-length-check Subjective preference; increases character count
filename-case Subjective naming preference #896
no-array-callback-reference Subjective preference; not always cleaner code
no-array-reduce Subjective code structure preference #896
no-await-expression-member Subjective preference; not always cleaner code
no-for-loop Subjective preference; not always optimal
no-nested-ternary Very opinionated; some projects need this #896
no-null Subjective preference some libraries don't work with #896
prefer-export-from Subjective preference; not always less code
prefer-query-selector Subjective preference not relevant to all projects #896
prefer-spread Subjective preference; doesn't impact control flow
prevent-abbreviations Subjective naming preference #896
switch-case-braces Subjective preference; not always cleaner code
template-indent Conflicts with Vitest-style .toMatchInlineSnapshot()

This unopinionated config does include the following rules that were mentioned as being candidates for removal:

Rule Reason Mentioned
no-useless-undefined Legitimate improvement; consistent-return doesn't enforce correctness #2715

I recognize I'm not an expert on this plugin and look forward to learning why some rules should(n't) be on those lists. ☺️

@fisker
Copy link
Collaborator

fisker commented Aug 7, 2025

I don't think "Type safety makes this much less useful" is a good reason to make rule 'opinionated'.

If I understand it correctly. It should only include rules for correctness, there should be only a few rules.

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the config-unopinionated branch 2 times, most recently from 45b069b to b31c759 Compare August 7, 2025 15:47
@fisker
Copy link
Collaborator

fisker commented Aug 7, 2025 •
edited
Loading

Rules like consistent-assert, consistent-empty-array-spread are 'opinionated'.

Strictly speaking, part of no-useless-undefined are 'unopinionated', these examples are very "stupid" as JS code https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-useless-undefined.md#fail

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 7, 2025 17:43
@JoshuaKGoldberg
Copy link
Author

Ok I think I adjusted for that?

@sindresorhus sindresorhus requested a review from fisker August 11, 2025 09:43
fisker
fisker reviewed Sep 1, 2025
View reviewed changes
docs/rules/catch-error-name.md
@@ -1,6 +1,6 @@
# Enforce a specific parameter name in catch clauses

💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#recommended-config).
💼🚫 This rule is enabled in the ✅ `recommended` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#recommended-config). This rule is _disabled_ in the ☑️ `unopinionated` [config](https://github.com/sindresorhus/eslint-plugin-unicorn#recommended-config).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this rule is opinionated.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not following, it's disabled in the unopinionated config. I didn't mark this rule as opinionated. Is this a point of agreement, or...?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought it's enabled...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take another look.

fisker
fisker reviewed Sep 1, 2025
View reviewed changes
fisker
fisker reviewed Sep 1, 2025
View reviewed changes
fisker
fisker reviewed Sep 1, 2025
View reviewed changes
@fisker
Copy link
Collaborator

fisker commented Sep 1, 2025

I didn't go through all rules, but I still think there are too many rules in this preset.

fisker
fisker approved these changes Sep 1, 2025
View reviewed changes
Copy link
Collaborator

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fisker
Copy link
Collaborator

fisker commented Sep 1, 2025

Can you fix the conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

@fisker fisker fisker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unopinionated preset
3 participants
@JoshuaKGoldberg @fisker @sindresorhus