Parentheses in URLs break linkifying

[hkdobrev]

@fregante edit: Issue transferred from refined-github. This issue still happens in v3.1.0

---

See this line:

• in a blob
• in a diff

The URL contains parentheses which make the anchor cut off the URL in both the href and the visual link producing a wrong URL.

Original valid URL:

https://github.com/jserz/js_piece/blob/master/DOM/ParentNode/append()/append().md

[fregante]

Context: aca71b8

TL;DR: support was removed because we don't want the final ) inside markdown to be matched, .e.g [github](https://github.com) -> https://github.com)

[hkdobrev]

I think this should be covered by a more sophisticated regex which would make the matching non-greedy for the last parenthesis if it detects a markdown link. This may prove difficult, though and we could work around it by detecting if you're looking at markdown or not.

[sindresorhus]

See: kevva/url-regex#35 (comment) I think this can be fixed now. We need to use the lookbehind operator in the url-regex module and then use it in linkify-urls again.

[fregante]

Blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1225665

linkify-urls@3 implemented it but we're stuck on v2 because Firefox doesn't support it.

[fregante]

I transferred the issue here because this can't be solved in Refined GitHub