Use python 3.12 in circleci (#221)

* Use python 3.12 in circleci

* assertEquals -> assertEqual

* unpin pylint

* make pylint happy

Author: bryantgray

.circleci/config.yml

@@ -11,9 +11,9 @@ jobs:
       - run:
           name: 'Setup virtual env'
           command: |
-            uv venv --python 3.9 /usr/local/share/virtualenvs/tap-github
+            uv venv --python 3.12 /usr/local/share/virtualenvs/tap-github
             source /usr/local/share/virtualenvs/tap-github/bin/activate
-            uv pip install -U pip setuptools
+            uv pip install -U setuptools
             uv pip install .[dev]
       - run:
           name: 'JSON Validator'
@@ -24,7 +24,7 @@ jobs:
           name: 'pylint'
           command: |
             source /usr/local/share/virtualenvs/tap-github/bin/activate
-            pylint tap_github --disable 'missing-module-docstring,missing-function-docstring,missing-class-docstring,line-too-long,invalid-name,too-many-lines,consider-using-f-string,too-many-arguments,too-many-locals'
+            pylint tap_github --disable 'missing-module-docstring,missing-function-docstring,missing-class-docstring,line-too-long,invalid-name,too-many-lines,consider-using-f-string,too-many-arguments,too-many-positional-arguments,too-many-locals,unnecessary-lambda-assignment,unspecified-encoding'
       - run:
           name: 'Unit Tests'
           command: |

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+# 3.3.1
+  * Fix new pylint issues [#221](https://github.com/singer-io/tap-github/pull/221)
+
 # 3.3.0
   * Adds `forced_replication_method` and `parent_tap_stream_id` as discoverable metadata [#220](https://github.com/singer-io/tap-github/pull/220)
 

setup.py

@@ -3,7 +3,7 @@
 from setuptools import setup, find_packages
 
 setup(name='tap-github',
-      version='3.3.0',
+      version='3.3.1',
       description='Singer.io tap for extracting data from the GitHub API',
       author='Stitch',
       url='http://singer.io',
@@ -16,7 +16,7 @@
       ],
       extras_require={
           'dev': [
-              'pylint==2.6.2',
+              'pylint',
               'ipdb',
               'nose',
               'requests-mock==1.9.3'

tap_github/client.py

@@ -277,7 +277,7 @@ def extract_repos_from_config(self):
 
         unique_repos = set()
         # Insert the duplicate repos found in the config repo_paths into duplicates
-        duplicate_repos = [x for x in repo_paths if x in unique_repos or (unique_repos.add(x) or False)]
+        duplicate_repos = [x for x in repo_paths if x in unique_repos or (unique_repos.add(x))]
         if duplicate_repos:
             LOGGER.warning("Duplicate repositories found: %s and will be synced only once.", duplicate_repos)
 

tap_github/streams.py

@@ -125,7 +125,6 @@ def write_bookmarks(self, stream, selected_streams, bookmark_value, repo_path, s
         for child in stream_obj.children:
             self.write_bookmarks(child, selected_streams, bookmark_value, repo_path, state)
 
-    # pylint: disable=no-self-use
     def get_child_records(self,
                           client,
                           catalog,

tests/unittests/test_exception_handling.py

@@ -89,7 +89,7 @@ def test_error_message_and_call_count(self, mocked_parse_args, mocked_request, m
         self.assertEqual(str(e.exception), expected_error_message)
 
         # Verify the call count for each error.
-        self.assertEquals(call_count, mocked_request.call_count)
+        self.assertEqual(call_count, mocked_request.call_count)
 
     @mock.patch("tap_github.client.LOGGER.warning")
     def test_skip_404_error(self, mock_logger,  mocked_parse_args, mocked_request, mock_verify_access, mock_sleep):