Merge pull request #93 from singerla/fix-slide-master-background-image

Fix slide master background image

Author: singerla

__tests__/add-slide-master-auto-import.test.ts

@@ -11,6 +11,7 @@ test('Auto-import source slideLayout and -master', async () => {
   const pres = await automizer
     .loadRoot(`EmptyTemplate.pptx`)
     .load('SlidesWithAdditionalMaster.pptx')
+    .load('SlideMasterBackgrounds.pptx')
     .load('SlideMasters.pptx')
 
     // We can disable .addMaster according to "autoImportSlideMasters: true"
@@ -25,7 +26,8 @@ test('Auto-import source slideLayout and -master', async () => {
     .addSlide('SlidesWithAdditionalMaster.pptx', 1)
     .addSlide('SlideMasters.pptx', 3)
     .addSlide('SlideMasters.pptx', 2)
+    .addSlide('SlideMasterBackgrounds.pptx', 2)
     .write(`add-slide-master-auto-import.test.pptx`);
 
-  expect(pres.masters).toBe(5);
+  expect(pres.masters).toBe(6);
 });

__tests__/pptx-templates/SlideMasterBackgrounds.pptx

@@ -1,5 +1,5 @@
 import { XmlHelper } from '../helper/xml-helper';
-import { GeneralHelper } from '../helper/general-helper';
+import { GeneralHelper, vd } from '../helper/general-helper';
 import {
   ChartModificationCallback,
   ImportedElement,
@@ -174,12 +174,16 @@ export class Shape {
     );
   }
 
+  /*
+   * This will find all elements with a matching rId on a
+   * <p:cSld>, including related images at <p:bg> and <p:spTree>.
+   */
   async getElementsByRid(
     slideXml: XmlDocument,
     rId: string,
   ): Promise<XmlElement[]> {
     const sourceList = slideXml
-      .getElementsByTagName('p:spTree')[0]
+      .getElementsByTagName('p:cSld')[0]
       .getElementsByTagName(this.relRootTag);
 
     const sourceElements = XmlHelper.findByAttributeValue(

src/classes/shape.ts

@@ -5,20 +5,18 @@ const run = async () => {
   const automizer = new Automizer({
     templateDir: `${__dirname}/../__tests__/pptx-templates`,
     outputDir: `${__dirname}/../__tests__/pptx-output`,
-    removeExistingSlides: true,
+    autoImportSlideMasters: true,
   });
 
   let pres = automizer
-    .loadRoot(`SlidesWithoutCreationIds.pptx`)
-    .load(`SlideWithCharts.pptx`, 'noCreationId');
+    .loadRoot(`RootTemplate.pptx`)
+    .load(`SlideMasterBackgrounds.pptx`);
 
-  pres.addSlide('noCreationId', 1, async (slide) => {
-    // const elements = await slide.getAllElements();
-    // const textElements = await slide.getAllTextElementIds();
-    vd(await slide.getDimensions());
+  pres.addSlide(`SlideMasterBackgrounds.pptx`, 2, async (slide) => {
+    console.log('test');
   });
 
-  pres.write(`myOutputPresentation.pptx`).then((summary) => {
+  pres.write(`SlideMasterBackgroundsOutput.pptx`).then((summary) => {
     console.log(summary);
   });
 };

src/dev.ts

@@ -62,9 +62,11 @@ export type AutomizerParams = {
   presTemplates?: string[];
   useCreationIds?: boolean;
   /**
-   * If you have trouble with messed up slideMasters, and if you don't worry
-   * about the impact on performance, you can try this to always import all
-   * required files:
+   * Turn this to true if you always want to import all required slide masters.
+   * You don't need to adjust with slide.useSlideLayout, but it will have a
+   * negative impact on performance.
+   * It is highly recommended to activate autoImportSlideMasters in case your
+   * loaded templates have different sets of slideMasters & -layouts.
    */
   autoImportSlideMasters?: boolean;
   /**