chore(chart): modify chart point border

Author: singerla

src/helper/modify-color-helper.ts

@@ -8,6 +8,8 @@ export default class ModifyColorHelper {
    * Replaces or creates an <a:solidFill> Element
    */
   static solidFill = (color: Color, index?:number|'last') => (element: Element): void => {
+    if(!color?.type) return
+
     const solidFills = element.getElementsByTagName('a:solidFill')
 
     if(!solidFills.length) {
@@ -31,5 +33,13 @@ export default class ModifyColorHelper {
 
     XmlHelper.sliceCollection(solidFill.childNodes as unknown as HTMLCollectionOf<Element>, 0)
     solidFill.appendChild(colorType)
+
+  }
+
+  static removeNoFill = () => (element: Element): void => {
+    const hasNoFill = element.getElementsByTagName('a:noFill')[0]
+    if(hasNoFill) {
+      element.removeChild(hasNoFill)
+    }
   }
 }

src/modify/modify-chart.ts

@@ -8,7 +8,7 @@ import {
   ChartDataMapper,
   ChartSeries, ChartValueStyle,
 } from '../types/chart-types';
-import {ModificationTags, Modification, Color} from '../types/modify-types';
+import {ModificationTags, Modification, Color, ModifyCallback} from '../types/modify-types';
 import { XmlHelper } from '../helper/xml-helper';
 import CellIdHelper from '../helper/cell-id-helper';
 import { Workbook } from '../types/types';
@@ -289,9 +289,10 @@ export class ModifyChart {
             modify: ModifyXmlHelper.attribute('val', idx)
           },
           'c:spPr': {
-            modify: ModifyColorHelper.solidFill(style.color),
+            modify: ModifyColorHelper.solidFill(style?.color),
           },
-          ...this.chartPointMarker(style.marker)
+          ...this.chartPointBorder(style?.border),
+          ...this.chartPointMarker(style?.marker)
         }
       }
     }
@@ -311,6 +312,24 @@ export class ModifyChart {
       }
     }
   }
+  chartPointBorder = (style: ChartValueStyle['border']): ModificationTags => {
+    if(!style) return
+    const modify = <ModifyCallback[]>[]
+
+    if(style.color) {
+      modify.push(ModifyColorHelper.solidFill(style.color))
+      modify.push(ModifyColorHelper.removeNoFill())
+    }
+    if(style.weight) {
+      modify.push(ModifyXmlHelper.attribute('w', style.weight))
+    }
+
+    return {
+      'a:ln': {
+        modify: modify
+      }
+    }
+  }
 
   seriesId = (series: number): ModificationTags => {
     return {

src/types/chart-types.ts

@@ -5,7 +5,11 @@ export type ChartValueStyle = {
   color?: Color;
   marker?: {
     color?: Color;
-  }
+  };
+  border?: {
+    color?: Color;
+    weight?: number;
+  };
   label?: {
     color?: Color;
     isBold?: Boolean