Skip to content

Commit aac8813

Browse files
[r] Skip tests using deprecated code in envs with lifecycle < 1.0.5 (#4395) (#4396)
* update tests to skip lifecycle condition warnings lifecycle 1.0.4 emits a lifecycle_stage condition even when lifecycle_verbosity = "quiet", which causes expect_no_condition() to fail * Remove duplicate lifecycle dependency (cherry picked from commit 6173f24) Co-authored-by: Aaron Wolen <aaron@wolen.com>
1 parent da72c64 commit aac8813

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

apis/r/DESCRIPTION

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ Imports:
5050
stats,
5151
tiledb (>= 0.34.0),
5252
tools,
53-
lifecycle,
5453
utils
5554
LinkingTo:
5655
nanoarrow,

apis/r/tests/testthat/test-03-SOMATileDBContext.R

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ test_that("SOMATileDBContext mechanics", {
1818

1919
test_that("SOMATileDBContext SOMA mechanics", {
2020
skip_if(!extended_tests())
21+
# lifecycle 1.0.4 emits a lifecycle_stage condition even when
22+
# lifecycle_verbosity = "quiet", which causes expect_no_condition() to fail
23+
skip_if_not_installed("lifecycle", minimum_version = "1.0.5")
2124
withr::local_options(lifecycle_verbosity = "quiet")
2225

2326
ctx <- SOMATileDBContext$new()
@@ -52,6 +55,7 @@ test_that("SOMATileDBContext SOMA mechanics", {
5255

5356
test_that("SOMATileDBContext TileDB mechanics", {
5457
skip_if(!extended_tests())
58+
skip_if_not_installed("lifecycle", minimum_version = "1.0.5")
5559
withr::local_options(lifecycle_verbosity = "quiet")
5660

5761
ctx <- SOMATileDBContext$new()
@@ -78,6 +82,7 @@ test_that("SOMATileDBContext TileDB mechanics", {
7882

7983
test_that("SOMATileDBContext SOMA + TileDB mechanics", {
8084
skip_if(!extended_tests())
85+
skip_if_not_installed("lifecycle", minimum_version = "1.0.5")
8186
withr::local_options(lifecycle_verbosity = "quiet")
8287

8388
ctx <- SOMATileDBContext$new()

0 commit comments

Comments
 (0)