Skip to content

Commit dfb0245

Browse files
authored
[r] Drop data.table as a dependency (#4398)
* Replace data.table::address with rlang::obj_address * Remove .import_helper() * Update news * Roxygenize
1 parent 7c97bf2 commit dfb0245

38 files changed

+52
-69
lines changed

apis/r/DESCRIPTION

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,13 @@ Encoding: UTF-8
3030
Additional_repositories: https://tiledb-inc.r-universe.dev,
3131
https://bnprks.r-universe.dev/
3232
Roxygen: list(markdown = TRUE)
33-
RoxygenNote: 7.3.2
33+
RoxygenNote: 7.3.3
3434
VignetteBuilder: knitr
3535
Depends:
3636
R (>= 4.1.0)
3737
Imports:
3838
arrow (>= 19.0.1),
3939
bit64 (>= 4.6.0.1),
40-
data.table,
4140
fs,
4241
glue,
4342
lifecycle,

apis/r/NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
## Changed
88

9+
- Removed `data.table` package dependency by leveraging `rlang::obj_address()` for generating ephemeral collection URIs.
910
- `ManagedQuery` reuses the same buffers for each incomplete read and allocates dedicated buffers when converting to Arrow. ([#4299](https://github.com/single-cell-data/TileDB-SOMA/pull/4299))
1011
- Default log level changed from `info` to `warn` to reduce verbosity. Use `set_log_level("info")` or the `SPDLOG_LEVEL` environment variable to restore verbose logging. ([#4393](https://github.com/single-cell-data/TileDB-SOMA/pull/4393))
1112

apis/r/R/ephemeral.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ EphemeralCollectionBase <- R6::R6Class(
294294
if (!missing(value)) {
295295
private$.read_only_error("uri")
296296
}
297-
return(paste0("ephemeral-collection:", data.table::address(self)))
297+
return(paste0("ephemeral-collection:", rlang::obj_address(self)))
298298
},
299299

300300
#' @field members A list with the members of this collection

apis/r/R/zzz.R

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,6 @@ NULL
1212

1313
.pkgenv <- new.env(parent = emptyenv())
1414

15-
#' Import Helper
16-
#'
17-
#' \code{R CMD check} tries to check use of all imported dependencies; however,
18-
#' it sometimes misses, such as in R6 methods. This function exists to satiate
19-
#' \code{R CMD check} by showing usage of imported dependencies.
20-
#'
21-
#' @return Invisibly returns \code{NULL}.
22-
#'
23-
#' @keywords internal
24-
#'
25-
#' @noRd
26-
#'
27-
.import_helper <- function() {
28-
data.table::address
29-
return(invisible(NULL))
30-
}
31-
3215
## .onLoad is called whether code from the package is used and the packages is 'loaded'. An
3316
## example is calling `tiledbsoma::show_package_versions()`. So this is most elementary check,
3417
## .onAttach is also called when the package is 'attached' via 'library(tiledbsoma)'

apis/r/man/BlockwiseSparseReadIter.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/r/man/BlockwiseTableReadIter.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/r/man/CoordsStrider.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/r/man/EphemeralCollection.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/r/man/EphemeralExperiment.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/r/man/SOMACollection.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)