Merge pull request #9 from milind-shakya-sp/fix_interval_schedulers

Fix interval schedulers

Author: milind-shakya-sp

.bumpversion.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 1.3.0
+current_version = 1.4.0
 commit = True
 tag = True
 parse = (?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(?P<releaselevel>[a-z]+)?

Changelog

@@ -4,6 +4,16 @@
  Change history
 ================
 
+.. _version-1.4.0:
+
+1.4.0
+=====
+:release-date: 2018-12-09 1:30 p.m. UTC+2:00
+:release-by: Omer Katz
+
+- Fix migrations dependencies.
+- Added the DJANGO_CELERY_BEAT_TZ_AWARE setting.
+
 .. _version-1.3.0:
 
 1.3.0

README.rst

@@ -8,7 +8,7 @@
 
 |build-status| |coverage| |license| |wheel| |pyversion| |pyimp|
 
-:Version: 1.3.0
+:Version: 1.4.0
 :Web: http://django-celery-beat.readthedocs.io/
 :Download: http://pypi.python.org/pypi/django-celery-beat
 :Source: http://github.com/celery/django-celery-beat

django_celery_beat/__init__.py

@@ -10,7 +10,7 @@
 
 from collections import namedtuple
 
-__version__ = '1.3.0+singleplatform.1'
+__version__ = '1.4.0+singleplatform.1'
 __author__ = 'Ask Solem'
 __contact__ = '[email protected]'
 __homepage__ = 'https://github.com/celery/django-celery-beat'

django_celery_beat/models.py

@@ -108,6 +108,15 @@ def __str__(self):
         )
 
 
+class TZNaiveSchedule(schedules.schedule):
+
+    def maybe_make_aware(self, dt):
+        """
+        Overriding the base method, to be a no-op and returning the dt as is.
+        """
+        return dt
+
+
 @python_2_unicode_compatible
 class IntervalSchedule(models.Model):
     """Schedule executing every n seconds."""
@@ -134,10 +143,15 @@ class Meta:
 
     @property
     def schedule(self):
-        return schedules.schedule(
+        _schedule = TZNaiveSchedule(
             timedelta(**{self.period: self.every}),
-            nowfun=lambda: make_aware(now())
         )
+        if getattr(settings, 'DJANGO_CELERY_BEAT_TZ_AWARE', True):
+            _schedule = schedules.schedule(
+                timedelta(**{self.period: self.every}),
+                nowfun=lambda: make_aware(now())
+            )
+        return _schedule
 
     @classmethod
     def from_schedule(cls, schedule, period=SECONDS):
@@ -218,7 +232,7 @@ def schedule(self):
             day_of_month=self.day_of_month,
             month_of_year=self.month_of_year,
         )
-        if settings.DJANGO_CELERY_BEAT_TZ_AWARE:
+        if getattr(settings, 'DJANGO_CELERY_BEAT_TZ_AWARE', True):
             crontab = TzAwareCrontab(
                 minute=self.minute,
                 hour=self.hour,

django_celery_beat/schedulers.py

@@ -94,7 +94,7 @@ def __init__(self, model, app=None):
 
         last_run_at = model.last_run_at
 
-        if settings.DJANGO_CELERY_BEAT_TZ_AWARE:
+        if getattr(settings, 'DJANGO_CELERY_BEAT_TZ_AWARE', True):
             last_run_at = make_aware(last_run_at)
 
         self.last_run_at = last_run_at
@@ -133,7 +133,7 @@ def _default_now(self):
         # The PyTZ datetime must be localised for the Django-Celery-Beat
         # scheduler to work. Keep in mind that timezone arithmatic
         # with a localized timezone may be inaccurate.
-        if settings.DJANGO_CELERY_BEAT_TZ_AWARE:
+        if getattr(settings, 'DJANGO_CELERY_BEAT_TZ_AWARE', True):
             now = now.tzinfo.localize(now.replace(tzinfo=None))
         return now
 
@@ -151,7 +151,7 @@ def save(self):
         for field in self.save_fields:
             setattr(obj, field, getattr(self.model, field))
 
-        if not settings.DJANGO_CELERY_BEAT_TZ_AWARE:
+        if not getattr(settings, 'DJANGO_CELERY_BEAT_TZ_AWARE', True):
             obj.last_run_at = datetime.datetime.now()
 
         obj.save()

docs/includes/introduction.txt

@@ -1,4 +1,4 @@
-:Version: 1.3.0
+:Version: 1.4.0
 :Web: http://django-celery-beat.readthedocs.io/
 :Download: http://pypi.python.org/pypi/django-celery-beat
 :Source: http://github.com/celery/django-celery-beat