Skip to content

Commit 4135c63

Browse files
committed
exception handling on user address api
1 parent bf15304 commit 4135c63

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

metering/handlers/usage_handler.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from constants import StatusCode, StatusMessage
55
from logger import setup_logger
66
from services import UsageService
7+
from settings import PAYMENT_MODE_FREECALL_VALUE
78
from utils import validate_request, make_response
89

910
usage_service = UsageService()
@@ -28,7 +29,7 @@ def add_verify_fields(usage_detail_dict):
2829
usage_detail_dict[key] = None
2930

3031
if usage_detail_dict['username'] is not None and usage_detail_dict['user_address'] is None:
31-
usage_detail_dict['payment_mode'] = 'freecall'
32+
usage_detail_dict['payment_mode'] = PAYMENT_MODE_FREECALL_VALUE
3233
else:
3334
usage_detail_dict['payment_mode'] = 'paid'
3435
return usage_detail_dict

metering/services.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def save_usage_details(self, usage_details_dict):
4040

4141

4242
class APIUtilityService:
43-
lambda_client = boto3.client('lambda', aws_access_key_id='AKIAXYSEM4MOHSXERFWL', aws_secret_access_key='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', region_name='us-east-1')
43+
lambda_client = boto3.client('lambda')
4444

4545
def get_user_address(self, group_id, channel_id):
4646
lambda_payload = {

metering/utils.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import logging
22

3+
from settings import PAYMENT_MODE_FREECALL_VALUE
4+
35

46
def make_response(status_code, body, header=None):
57
return {
@@ -35,6 +37,6 @@ def validator_usage():
3537

3638

3739
def is_free_call(usage_details_dict):
38-
if usage_details_dict['payment_mode'] == 'free_call':
40+
if usage_details_dict['payment_mode'] == PAYMENT_MODE_FREECALL_VALUE:
3941
return True
4042
return False

0 commit comments

Comments
 (0)