fix bug with instance run command (#214)

* fix bug with instance run command

the incorrect function is exposed for instance.run_command
it is missing the self parameter, and so the instance (self)
is passed as the command.

Signed-off-by: vsoch <[email protected]>

Author: vsoch

CHANGELOG.md

@@ -17,6 +17,7 @@ The client here will eventually be released as "spython" (and eventually to
 singularity on pypi), and the versions here will coincide with these releases.
 
 ## [master](https://github.com/singularityhub/singularity-cli/tree/master)
+ - bug with instance.run_command (0.3.12)
  - added check to enbsure stderr exists upon a non-zero return code when streaming (0.3.11)
  - exposed the stream type option, and ability to capture both stdout and stderr when stream=True (0.3.1)
  - dropping support for Singularity 2.x (0.3.0)

setup.py

@@ -1,14 +1,3 @@
-"""
-
-Copyright (C) 2017-2021 Vanessa Sochat.
-
-This Source Code Form is subject to the terms of the
-Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed
-with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-"""
-
-
 import os
 
 from setuptools import find_packages, setup

spython/__init__.py

@@ -1,11 +1 @@
-"""
-
-Copyright (C) 2017-2022 Vanessa Sochat.
-
-This Source Code Form is subject to the terms of the
-Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed
-with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-"""
-
 from spython.version import __version__

spython/client/__init__.py

@@ -1,12 +1,11 @@
 #!/usr/bin/env python
 
-# Copyright (C) 2017-2022 Vanessa Sochat.
+# Copyright (C) 2017-2024 Vanessa Sochat.
 
 # This Source Code Form is subject to the terms of the
 # Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed
 # with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
-
 import argparse
 import os
 import sys

spython/client/recipe.py

@@ -1,4 +1,4 @@
-# Copyright (C) 2017-2022 Vanessa Sochat.
+# Copyright (C) 2017-2024 Vanessa Sochat.
 
 # This Source Code Form is subject to the terms of the
 # Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed

spython/client/shell.py

@@ -1,4 +1,4 @@
-# Copyright (C) 2017-2022 Vanessa Sochat.
+# Copyright (C) 2017-2024 Vanessa Sochat.
 
 # This Source Code Form is subject to the terms of the
 # Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed

spython/client/test.py

@@ -1,4 +1,4 @@
-# Copyright (C) 2017-2022 Vanessa Sochat.
+# Copyright (C) 2017-2024 Vanessa Sochat.
 
 # This Source Code Form is subject to the terms of the
 # Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed

spython/image.py

@@ -1,9 +1,10 @@
-# Copyright (C) 2017-2022 Vanessa Sochat.
+# Copyright (C) 2017-2024 Vanessa Sochat.
 
 # This Source Code Form is subject to the terms of the
 # Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed
 # with this file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+
 import hashlib
 import os
 

spython/instance/__init__.py

@@ -1,4 +1,4 @@
-# Copyright (C) 2017-2022 Vanessa Sochat.
+# Copyright (C) 2017-2024 Vanessa Sochat.
 
 # This Source Code Form is subject to the terms of the
 # Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed

spython/instance/cmd/__init__.py

@@ -1,4 +1,4 @@
-# Copyright (C) 2017-2022 Vanessa Sochat.
+# Copyright (C) 2017-2024 Vanessa Sochat.
 
 # This Source Code Form is subject to the terms of the
 # Mozilla Public License, v. 2.0. If a copy of the MPL was not distributed
@@ -18,16 +18,14 @@ def generate_instance_commands():
     from spython.main.base.generate import RobotNamer
     from spython.main.base.logger import println
     from spython.main.instances import list_instances
-    from spython.utils import run_command as run_cmd
 
     from .logs import _logs, error_logs, output_logs
     from .start import start
     from .stop import stop
 
     Instance.RobotNamer = RobotNamer()
     Instance._init_command = init_command
-    Instance.run_command = run_cmd
-    Instance._run_command = run_command
+    Instance.run_command = run_command
     Instance._list = list_instances  # list command is used to get metadata
     Instance._println = println
     Instance.start = start  # intended to be called on init, not by user