Skip to content

Commit e79bc91

Browse files
committed
fixing fromHeader bug
1 parent 3280d5e commit e79bc91

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ The client here will eventually be released as "spython" (and eventually to
1717
singularity on pypi), and the versions here will coincide with these releases.
1818

1919
## [master](https://github.com/singularityhub/singularity-cli/tree/master)
20+
- bug in Dockerfile fromHeader variable fix (0.0.29)
2021
- Dockerfile from "as level" removed (0.0.28)
2122
- fixed ENV parser to handle statements like A=B C=D
2223
- adding ability to stream command executed to console (0.0.25)

spython/main/parse/converters.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ def docker2singularity(self, runscript="/bin/bash", force=False):
207207
'''
208208

209209
recipe = ['Bootstrap: docker']
210-
recipe += [ "From: %s" %self.fromHeader[0] ]
210+
recipe += [ "From: %s" %self.fromHeader ]
211211

212212
# Sections with key value pairs
213213
recipe += self._create_section('files')

spython/main/parse/docker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def _from(self, line):
6868
fromHeader = self._setup('FROM', line)
6969

7070
# Singularity does not support AS level
71-
self.fromHeader = re.sub("AS .+", "", fromHeader, flags=re.I)
71+
self.fromHeader = re.sub("AS .+", "", fromHeader[0], flags=re.I)
7272

7373
if "scratch" in self.fromHeader:
7474
bot.warning('scratch is no longer available on Docker Hub.')

spython/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919

2020

21-
__version__ = "0.0.28"
21+
__version__ = "0.0.29"
2222
AUTHOR = 'Vanessa Sochat'
2323
AUTHOR_EMAIL = '[email protected]'
2424
NAME = 'spython'

0 commit comments

Comments
 (0)