Skip to content

Commit f5fe041

Browse files
authored
Merge pull request #463 from singularityhub/quote-labels
labels in tcl files should be quoted
2 parents 5fa3788 + 17251be commit f5fe041

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
1414
The versions coincide with releases on pip. Only major versions will be released as tags on Github.
1515

1616
## [0.0.x](https://github.scom/singularityhub/singularity-hpc/tree/master) (0.0.x)
17+
- Adding quotes around tcl descriptions (0.0.37)
1718
- fixing bug with container install (does not honor module directory) (0.0.36)
1819
- `.version` file should be written in top level of module folders [#450](https://github.com/singularityhub/singularity-hpc/issues/450) (0.0.35)
1920
- tcl module functions need `$@` to handle additional arguments

shpc/main/modules/templates/docker.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ set workdir [pwd]
4747
{% if description %}set notes "{{ description }}"{% endif %}
4848
{% if url %}set homepage "{{ url }}"{% endif %}
4949
set helpcommand "This module is a {{ docker }} container wrapper for {{ name }} v{{ version }}. {% if description %}{{ description }}{% endif %}"
50-
{% if labels %}{% for key, value in labels.items() %}set {{ key }} {{ value }}
50+
{% if labels %}{% for key, value in labels.items() %}set {{ key }} "{{ value }}"
5151
{% endfor %}{% endif %}
5252

5353
# conflict with modules with the same alias name

shpc/main/modules/templates/singularity.tcl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ set containerPath {{ container_sif }}
5353
{% if description %}set notes "{{ description }}"{% endif %}
5454
{% if url %}set homepage "{{ url }}"{% endif %}
5555
set helpcommand "This module is a singularity container wrapper for {{ name }} v{{ version }}. {% if description %}{{ description }}{% endif %}"
56-
{% if labels %}{% for key, value in labels.items() %}set {{ key }} {{ value }}
56+
{% if labels %}{% for key, value in labels.items() %}set {{ key }} "{{ value }}"
5757
{% endfor %}{% endif %}
5858

5959
# conflict with modules with the same alias name

shpc/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
__copyright__ = "Copyright 2021, Vanessa Sochat"
33
__license__ = "MPL 2.0"
44

5-
__version__ = "0.0.36"
5+
__version__ = "0.0.37"
66
AUTHOR = "Vanessa Sochat"
77
NAME = "singularity-hpc"
88
PACKAGE_URL = "https://github.com/singularityhub/singularity-hpc"

0 commit comments

Comments
 (0)