File tree Expand file tree Collapse file tree 4 files changed +7
-11
lines changed Expand file tree Collapse file tree 4 files changed +7
-11
lines changed Original file line number Diff line number Diff line change @@ -14,6 +14,7 @@ and **Merged pull requests**. Critical items to know are:
14
14
The versions coincide with releases on pip. Only major versions will be released as tags on Github.
15
15
16
16
## [ 0.0.x] ( https://github.scom/singularityhub/singularity-hpc/tree/master ) (0.0.x)
17
+ - Cleanup of module files and docker requirement bugfix (0.0.27)
17
18
- Docker support (0.0.26)
18
19
- added an enable_tty setting to allow disabling add -t in recipes
19
20
- enforced not adding extra settings to setting.yml
Original file line number Diff line number Diff line change @@ -25,8 +25,11 @@ class DockerContainer(ContainerTechnology):
25
25
features = {}
26
26
27
27
def __init__ (self ):
28
- if shpc .utils .which ("docker" )["return_code" ] != 0 :
29
- logger .exit ("Docker is required to use the 'docker' base." )
28
+ if shpc .utils .which (self .command )["return_code" ] != 0 :
29
+ logger .exit (
30
+ "%s is required to use the '%s' base."
31
+ % (self .command .capitalize (), self .command )
32
+ )
30
33
super (DockerContainer , self ).__init__ ()
31
34
32
35
def shell (self , image ):
Original file line number Diff line number Diff line change 3
3
__license__ = "MPL 2.0"
4
4
5
5
6
- from shpc .logger import logger
7
6
from .docker import DockerContainer
8
- import shpc .main .templates
9
- import shpc .utils
10
7
11
8
import os
12
9
@@ -20,11 +17,6 @@ class PodmanContainer(DockerContainer):
20
17
templatefile = "docker"
21
18
command = "podman"
22
19
23
- def __init__ (self ):
24
- if shpc .utils .which ("podman" )["return_code" ] != 0 :
25
- logger .exit ("podman is required to use the podman base." )
26
- super (PodmanContainer , self ).__init__ ()
27
-
28
20
def shell (self , image ):
29
21
"""
30
22
Interactive shell into a container image.
Original file line number Diff line number Diff line change 2
2
__copyright__ = "Copyright 2021, Vanessa Sochat"
3
3
__license__ = "MPL 2.0"
4
4
5
- __version__ = "0.0.26 "
5
+ __version__ = "0.0.27 "
6
6
AUTHOR = "Vanessa Sochat"
7
7
NAME = "singularity-hpc"
8
8
PACKAGE_URL = "https://github.com/singularityhub/singularity-hpc"
You can’t perform that action at this time.
0 commit comments