change: s3 and s3_external obj in minio.py for SSL use (#384)

* Set attributes correctly for SSL use

The 'verify' attribute is now correctly set to True or False, accordingly to the MINIO_SSL variable which determines if SSL is used in the setup.

* Updatet s3 and s3_external obj in minio.py for SSL use (#380)

add: auto set "verify" attribute of s3 and s3_external obj in minio.py for SSL use (1.1.39). See #380 for more info

Author: hashkeks

CHANGELOG.md

@@ -12,6 +12,7 @@ represented by the pull requests that fixed them. Critical items to know are:
 
 
 ## [master](https://github.com/singularityhub/sregistry/tree/master) (master)
+ - add: auto set "verify" attribute of s3 and s3_external obj in minio.py for SSL use (1.1.39) 
  - fix issues with psycopg2-binary and saml auth (1.1.38)
    - Pin psycopg2-binary 2.8.6 to deal with UTC errors
    - change formatting of the login URL to fix saml auth

VERSION

@@ -1 +1 @@
-1.1.38
+1.1.39

shub/apps/library/views/minio.py

@@ -72,7 +72,7 @@
 # https://github.com/boto/boto3/blob/develop/boto3/session.py#L185
 s3 = session.client(
     "s3",
-    verify=False,
+    verify=MINIO_SSL,
     use_ssl=MINIO_SSL,
     endpoint_url=MINIO_HTTP_PREFIX + MINIO_SERVER,
     region_name=MINIO_REGION,
@@ -83,10 +83,10 @@
 # https://github.com/boto/botocore/blob/master/botocore/auth.py#L846
 s3_external = session.client(
     "s3",
+    verify=MINIO_SSL,
     use_ssl=MINIO_SSL,
-    region_name=MINIO_REGION,
     endpoint_url=MINIO_HTTP_PREFIX + MINIO_EXTERNAL_SERVER,
-    verify=False,
+    region_name=MINIO_REGION,
     config=Config(signature_version="s3v4", s3={"addressing_style": "path"}),
 )