Skip to content

Commit 0a0c4ae

Browse files
authored
fix: check vardef.regions instead of vardef in transfer_variables_or_parameters! (#213)
`!isnothing(vardef)` trivially always true; should be `!isnothing(vardef.regions)`. When a variable has `regions = nothing` (single-region model default), the old condition entered the branch and called `empty!(nothing)`, crashing with a MethodError. This blocked the `setup_reservoir_model(reservoir, template; wells=...)` overload from working on any standard single-region model.
1 parent 86b178a commit 0a0c4ae

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/utils.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2798,7 +2798,7 @@ function transfer_variables_or_parameters!(vars, new_model::SimulationModel, rep
27982798
end
27992799
Jutul.delete_variable!(new_model, varname)
28002800
vardef = deepcopy(vardef)
2801-
if hasproperty(vardef, :regions) && !isnothing(vardef)
2801+
if hasproperty(vardef, :regions) && !isnothing(vardef.regions)
28022802
entity = Jutul.associated_entity(vardef)
28032803
n = count_entities(new_model.domain.representation, entity)
28042804
empty!(vardef.regions)

0 commit comments

Comments
 (0)