♻️ refactor error handling and logging in streamContacts

Author: vogelskamp

src/models/controller.model.ts

@@ -14,7 +14,6 @@ import {
   ServerError,
 } from ".";
 import { calendarEventsSchema, contactsSchema } from "../schemas";
-import { isProduction } from "../util";
 import { shouldSkipCallEvent } from "../util/call-event.util";
 import { errorLogger, infoLogger } from "../util/logger.util";
 import { parsePhoneNumber } from "../util/phone-number-utils";
@@ -54,12 +53,13 @@ export class Controller {
     this.contactCache = contactCache;
     this.ajv = new Ajv();
 
-    const { PUBSUB_TOPIC_NAME: topicName } = process.env;
+    if (this.adapter.streamContacts) {
+      const { PUBSUB_TOPIC_NAME: topicName } = process.env;
 
-    if (isProduction() && typeof this.adapter.streamContacts === "function") {
       if (!topicName) {
         throw new Error("No pubsub topic name provided.");
       }
+
       this.pubSubClient = new PubSubClient(topicName);
       infoLogger(
         "Controller",
@@ -215,7 +215,7 @@ export class Controller {
           } catch (error) {
             errorLogger(
               "streamContacts",
-              "Could not publish contacts",
+              `Could not publish contacts`,
               providerConfig.apiKey,
               error
             );

src/models/pubsub-client.model.ts

@@ -1,5 +1,4 @@
 import { PubSub } from "@google-cloud/pubsub";
-import { errorLogger, infoLogger } from "../util";
 import { PubSubContactsMessage } from "./pubsub-contacts-message.model";
 
 export class PubSubClient {
@@ -12,24 +11,13 @@ export class PubSubClient {
   }
 
   async publishMessage(message: PubSubContactsMessage) {
-    try {
-      if (!this.topicName) {
-        throw new Error("No pubsub topic name provided.");
-      }
-
-      const json = JSON.stringify(message);
-      const dataBuffer = Buffer.from(json);
-      const topic = this.client.topic(this.topicName);
-      await topic.publishMessage({ data: dataBuffer });
-
-      infoLogger(
-        PubSubClient.name,
-        `Published ${message.contacts.length} contacts for user ${message.userId} to topic ${this.topicName}`
-      );
-    } catch (error) {
-      console.error(error);
-      const message = (error as Error).message;
-      errorLogger(PubSubClient.name, `Could not publish to pubsub: ${message}`);
+    if (!this.topicName) {
+      throw new Error("No pubsub topic name provided.");
     }
+
+    const json = JSON.stringify(message);
+    const dataBuffer = Buffer.from(json);
+    const topic = this.client.topic(this.topicName);
+    await topic.publishMessage({ data: dataBuffer });
   }
 }