🐛 validate input before forwarding to adapter

Author: vogelskamp

package-lock.json

@@ -78,7 +78,6 @@
     "@opentelemetry/sdk-node": "^0.45.1",
     "@opentelemetry/sdk-trace-base": "^1.18.1",
     "@slack/webhook": "^6.1.0",
-    "ajv": "^8.11.0",
     "awesome-phonenumber": "^3.2.0",
     "axios": "^1.0.0",
     "body-parser": "^1.20.0",
@@ -91,6 +90,7 @@
     "lru-cache": "^7.13.1",
     "moment": "^2.29.4",
     "rate-limiter-flexible": "^2.3.11",
-    "redis": "^4.2.0"
+    "redis": "^4.2.0",
+    "zod": "^3.23.8"
   }
 }

package.json

@@ -18,7 +18,6 @@ import { TaskController } from './controllers/task.controller';
 import { errorHandlerMiddleware, extractHeaderMiddleware } from './middlewares';
 import {
   Adapter,
-  BridgeRequestWithTimestamp,
   ContactCache,
   Controller,
   IntegrationEntityBridgeRequest,
@@ -82,32 +81,12 @@ export function start(
     controller.streamContacts(req, res, next),
   );
 
-  app.get('/contacts-delta', (req: BridgeRequestWithTimestamp, res, next) =>
-    controller.getContactsDelta(req, res, next),
-  );
-
   app.get(
     '/entity/:type/:id',
     (req: IntegrationEntityBridgeRequest, res, next) =>
       controller.getEntity(req, res, next),
   );
 
-  app.get('/calendar', (req, res, next) =>
-    controller.getCalendarEvents(req, res, next),
-  );
-
-  app.post('/calendar', (req, res, next) =>
-    controller.createCalendarEvent(req, res, next),
-  );
-
-  app.put('/calendar/:id', (req, res, next) =>
-    controller.updateCalendarEvent(req, res, next),
-  );
-
-  app.delete('/calendar/:id', (req, res, next) =>
-    controller.deleteCalendarEvent(req, res, next),
-  );
-
   app.post('/events/calls', (req, res, next) =>
     controller.handleCallEvent(req, res, next),
   );

src/index.ts

@@ -1,13 +1,9 @@
 import { Request, Response } from 'express';
 import {
-  CalendarEvent,
-  CalendarEventTemplate,
-  CalendarFilterOptions,
   CallEvent,
   CallEventWithIntegrationEntities,
   Config,
   Contact,
-  ContactDelta,
   ContactTemplate,
   ContactUpdate,
   FollowUpWithIntegrationEntities,
@@ -29,10 +25,6 @@ export interface Adapter {
     type: IntegrationEntityType,
   ) => Promise<Contact>;
   getContacts?: (config: Config) => Promise<Contact[]>;
-  getContactsDelta?: (
-    config: Config,
-    timestamp: number,
-  ) => Promise<ContactDelta>;
   streamContacts?: (config: Config) => AsyncGenerator<Contact[], void, unknown>;
   createContact?: (
     config: Config,
@@ -44,21 +36,6 @@ export interface Adapter {
     contact: ContactUpdate,
   ) => Promise<Contact>;
   deleteContact?: (config: Config, id: string) => Promise<void>;
-  getCalendarEvents?: (
-    config: Config,
-    options?: CalendarFilterOptions | null,
-  ) => Promise<CalendarEvent[]>;
-  createCalendarEvent?: (
-    config: Config,
-    event: CalendarEventTemplate,
-  ) => Promise<CalendarEvent>;
-  updateCalendarEvent?: (
-    config: Config,
-    id: string,
-    event: CalendarEventTemplate,
-  ) => Promise<CalendarEvent>;
-
-  deleteCalendarEvent?: (config: Config, id: string) => Promise<void>;
   /**
    * @deprecated handleCallEvent should be replaced by createOrUpdateCallLogForEntities
    */

src/models/adapter.model.ts

@@ -56,8 +56,3 @@ export type ContactUpdate = ContactTemplate & {
 };
 
 export type Contact = ContactTemplate & ContactResult;
-
-export type ContactDelta = {
-  contacts: Contact[];
-  deleted: string[];
-};