🏗️ add type IdBridgeRequest with params.id

Author: MalteSehmer

src/models/bridge-request.model.ts

@@ -7,6 +7,10 @@ export interface BridgeRequest<BodyType> extends Request {
   body: BodyType;
 }
 
+export interface IdBridgeRequest<BodyType> extends BridgeRequest<BodyType> {
+  params: { id: string };
+}
+
 export interface IntegrationEntityBridgeRequest extends BridgeRequest<unknown> {
   params: { id: string; type: IntegrationEntityType };
 }

src/models/controller.model.test.ts

@@ -18,7 +18,7 @@ import {
 import { StorageCache } from "../cache";
 import { MemoryStorageAdapter } from "../cache/storage";
 import { APIContact } from "./api-contact.model";
-import { BridgeRequest } from "./bridge-request.model";
+import { BridgeRequest, IdBridgeRequest } from "./bridge-request.model";
 import { PhoneNumberLabel, PhoneNumberType } from "./contact.model";
 
 const contactsMock: APIContact[] = [
@@ -368,7 +368,7 @@ describe("createCalendarEvent", () => {
 });
 
 describe("updateCalendarEvent", () => {
-  let request: MockRequest<BridgeRequest<CalendarEventTemplate>>;
+  let request: MockRequest<IdBridgeRequest<CalendarEventTemplate>>;
   let response: MockResponse<Response>;
   let next: jest.Mock;
 
@@ -436,7 +436,7 @@ describe("updateCalendarEvent", () => {
 });
 
 describe("deleteCalendarEvent", () => {
-  let request: MockRequest<BridgeRequest<unknown>>;
+  let request: MockRequest<IdBridgeRequest<unknown>>;
   let response: MockResponse<Response>;
   let next: jest.Mock;
 

src/models/controller.model.ts

@@ -21,6 +21,7 @@ import { validate } from "../util/validate";
 import { APIContact } from "./api-contact.model";
 import {
   BridgeRequest,
+  IdBridgeRequest,
   IntegrationEntityBridgeRequest,
 } from "./bridge-request.model";
 import { CacheItemStateType } from "./cache-item-state.model";
@@ -201,7 +202,7 @@ export class Controller {
   }
 
   public async updateContact(
-    req: BridgeRequest<ContactUpdate>,
+    req: IdBridgeRequest<ContactUpdate>,
     res: Response,
     next: NextFunction
   ): Promise<void> {
@@ -265,7 +266,7 @@ export class Controller {
   }
 
   public async deleteContact(
-    req: BridgeRequest<unknown>,
+    req: IdBridgeRequest<unknown>,
     res: Response,
     next: NextFunction
   ): Promise<void> {
@@ -281,7 +282,7 @@ export class Controller {
 
       console.log(`Deleting contact for key "${anonymizeKey(apiKey)}"`);
 
-      const contactId: string = req.params.id;
+      const contactId = req.params.id;
       await this.adapter.deleteContact(req.providerConfig, contactId);
 
       if (this.adapter.getToken && req.providerConfig) {
@@ -414,7 +415,7 @@ export class Controller {
   }
 
   public async updateCalendarEvent(
-    req: BridgeRequest<CalendarEventTemplate>,
+    req: IdBridgeRequest<CalendarEventTemplate>,
     res: Response,
     next: NextFunction
   ): Promise<void> {
@@ -460,7 +461,7 @@ export class Controller {
   }
 
   public async deleteCalendarEvent(
-    req: BridgeRequest<unknown>,
+    req: IdBridgeRequest<unknown>,
     res: Response,
     next: NextFunction
   ): Promise<void> {