refactor: remove unnecessary test type annotations

Author: paulschwoerer

tests/test_rpc_matchers.py

@@ -8,7 +8,7 @@
 
 
 class TestSipgateRpcMatchers(TestCase):
-    def test_xml_rpc(self) -> None:
+    def test_xml_rpc(self):
         assertions = [
             (False, ('POST', '/jsonrpc', json.dumps({'method': 'test_method', 'version': '1.1', 'params': [], 'id': 42}).encode())),
             (False, ('POST', '/jsonrpc', b'<?xml version="1.0"?><methodCall><methodName>test_method</methodName><params><param><value></value></param></params></methodCall>')),
@@ -28,7 +28,7 @@ def test_xml_rpc(self) -> None:
 
                 self.assertEqual(expected, xml_rpc('test_method')(request))
 
-    def test_json_rpc(self) -> None:
+    def test_json_rpc(self):
         assertions = [
             (False, ('POST', '/rpc2', b'<?xml version="1.0"?><methodCall><methodName>test_method</methodName><params><param><value></value></param></params></methodCall>')),
             (False, ('POST', '/rpc2', json.dumps({'method': 'test_method', 'version': '1.1', 'params': [], 'id': 42}).encode())),

tests/test_xml_rpc_request.py

@@ -5,15 +5,15 @@
 
 
 class TestSipgateXmlRpcRequest(TestCase):
-    def test_empty_body(self) -> None:
+    def test_empty_body(self):
         with self.assertRaises(ParseError):
             XmlRpcRequest.parse('')
 
-    def test_non_xml_body(self) -> None:
+    def test_non_xml_body(self):
         with self.assertRaises(ParseError):
             XmlRpcRequest.parse("{'key': 'value'}")
 
-    def test_response_is_not_parsed_as_request(self) -> None:
+    def test_response_is_not_parsed_as_request(self):
         body = """<?xml version="1.0" encoding="UTF-8"?>
             <methodResponse>
                 <params><param><value>
@@ -27,7 +27,7 @@ def test_response_is_not_parsed_as_request(self) -> None:
         with self.assertRaises(ValueError):
             XmlRpcRequest.parse(body)
 
-    def test_method_name(self) -> None:
+    def test_method_name(self):
         body = """<?xml version="1.0"?>
                     <methodCall>
                         <methodName>a_method_name</methodName>
@@ -37,7 +37,7 @@ def test_method_name(self) -> None:
         parsed = XmlRpcRequest.parse(body)
         self.assertEqual('a_method_name', parsed.method_name)
 
-    def test_valid_members(self) -> None:
+    def test_valid_members(self):
         body = """<?xml version="1.0"?>
             <methodCall>
                 <methodName>a_method_name</methodName>
@@ -69,7 +69,7 @@ def test_valid_members(self) -> None:
         self.assertEqual(b'', parsed.members['base64_empty'])
         self.assertEqual(b'any_data', parsed.members['base64_data'])
 
-    def test_invalid_members(self) -> None:
+    def test_invalid_members(self):
         members = [
             {'name': 'bool_empty', 'value': '<boolean></boolean>'},
             {'name': 'bool_string', 'value': '<boolean>true</boolean>'},
@@ -92,7 +92,7 @@ def test_invalid_members(self) -> None:
                 with self.assertRaises(ValueError):
                     XmlRpcRequest.parse(body)
 
-    def test_unsupported_data_type(self) -> None:
+    def test_unsupported_data_type(self):
         body = """<?xml version="1.0"?>
                     <methodCall>
                         <methodName>a_method_name</methodName>
@@ -106,7 +106,7 @@ def test_unsupported_data_type(self) -> None:
         with self.assertRaises(NotImplementedError):
             XmlRpcRequest.parse(body)
 
-    def test_has_string_representation(self) -> None:
+    def test_has_string_representation(self):
         body = """<?xml version="1.0"?>
             <methodCall>
                 <methodName>another_method_name</methodName>
@@ -122,7 +122,7 @@ def test_has_string_representation(self) -> None:
         self.assertIn('TNB', f"{parsed}")
         self.assertIn('D111', f"{parsed}")
 
-    def test_also_accepts_bytes(self) -> None:
+    def test_also_accepts_bytes(self):
         body = b"""<?xml version="1.0"?>
                     <methodCall>
                         <methodName>a_method_name</methodName>
@@ -131,7 +131,7 @@ def test_also_accepts_bytes(self) -> None:
 
         XmlRpcRequest.parse(body)
 
-    def test_serialization_empty_request(self) -> None:
+    def test_serialization_empty_request(self):
         request = XmlRpcRequest('a_method', {})
 
         expected_body = """<?xml version="1.0"?>
@@ -143,7 +143,7 @@ def test_serialization_empty_request(self) -> None:
         # TODO: use better comparison, this would ignore spaces in values
         self.assertEqual(''.join(expected_body.split()), ''.join(request.serialize().split()))
 
-    def test_serialization(self) -> None:
+    def test_serialization(self):
         request = XmlRpcRequest('a_method', {
             'an_int': 42,
             'a_string': 'the_value',

tests/test_xml_rpc_response.py

@@ -5,15 +5,15 @@
 
 
 class TestSipgateXmlRpcResponse(TestCase):
-    def test_empty_body(self) -> None:
+    def test_empty_body(self):
         with self.assertRaises(ParseError):
             XmlRpcResponse.parse('')
 
-    def test_non_xml_body(self) -> None:
+    def test_non_xml_body(self):
         with self.assertRaises(ParseError):
             XmlRpcResponse.parse("{'key': 'value'}")
 
-    def test_request_is_not_parsed_as_response(self) -> None:
+    def test_request_is_not_parsed_as_response(self):
         body = """<?xml version="1.0" encoding="UTF-8"?>
             <methodCall>
                 <methodName>another_method_name</methodName>
@@ -27,7 +27,7 @@ def test_request_is_not_parsed_as_response(self) -> None:
         with self.assertRaises(ValueError):
             XmlRpcResponse.parse(body)
 
-    def test_parses_complex_success_response(self) -> None:
+    def test_parses_complex_success_response(self):
         body = """<?xml version="1.0"?>
             <methodResponse>
                 <params>
@@ -80,7 +80,7 @@ def test_parses_complex_success_response(self) -> None:
             'number': '0777',
         }], parsed.members['blocks'])
 
-    def test_parses_complex_error_response(self) -> None:
+    def test_parses_complex_error_response(self):
         body = """<?xml version="1.0"?>
             <methodResponse>
                     <fault><value>
@@ -104,7 +104,7 @@ def test_parses_complex_error_response(self) -> None:
         self.assertEqual((423, 'NOT_OK'), (parsed.fault_code, parsed.fault_string))
         self.assertTrue(['one', 'two'], parsed.members['things_that_went_wrong'])
 
-    def test_invalid_members(self) -> None:
+    def test_invalid_members(self):
         members = [
             {'name': 'bool_empty', 'value': '<boolean></boolean>'},
             {'name': 'bool_string', 'value': '<boolean>true</boolean>'},
@@ -126,7 +126,7 @@ def test_invalid_members(self) -> None:
                 with self.assertRaises(ValueError):
                     XmlRpcResponse.parse(body)
 
-    def test_call_has_string_representation(self) -> None:
+    def test_call_has_string_representation(self):
         body = """<?xml version="1.0"?>
                     <methodResponse>
                         <params>
@@ -142,7 +142,7 @@ def test_call_has_string_representation(self) -> None:
         parsed = XmlRpcResponse.parse(body)
         self.assertRegex(f"{parsed}", '^<XmlRpcResponse.*faultCode.*200.*>$')
 
-    def test_serialization_success_response(self) -> None:
+    def test_serialization_success_response(self):
         response = XmlRpcResponse(200, 'OK')
 
         expected_body = """<?xml version="1.0"?>
@@ -161,7 +161,7 @@ def test_serialization_success_response(self) -> None:
         #  this would ignore spaces in values and does not ignore order of params
         self.assertEqual(''.join(expected_body.split()), ''.join(response.serialize().split()))
 
-    def test_serialization_fault_response(self) -> None:
+    def test_serialization_fault_response(self):
         response = XmlRpcResponse(407, 'NOT SO OKAY')
 
         expected_body = """<?xml version="1.0"?>
@@ -178,7 +178,7 @@ def test_serialization_fault_response(self) -> None:
         #  this would ignore spaces in values and does not ignore order of params
         self.assertEqual(''.join(expected_body.split()), ''.join(response.serialize().split()))
 
-    def test_serialization(self) -> None:
+    def test_serialization(self):
         response = XmlRpcResponse(200, 'OK', {
             'an_int': 42,
             'a_string': 'the_value',