Refine systemd integration checks

Author: sobomax

.github/workflows/rtpproxy_ci.yml

@@ -135,6 +135,19 @@ jobs:
         fi
         sudo apt-get install -y "${pkgs[@]}"
 
+    - name: Exercise systemd service
+      run: |
+        set -euo pipefail
+        sudo systemctl daemon-reload
+        sudo systemctl enable --now rtpproxy.socket
+        sudo systemctl start rtpproxy.service
+        sudo systemctl status --no-pager rtpproxy.service
+        sudo systemctl restart rtpproxy.service
+        sudo systemctl status --no-pager rtpproxy.service
+        sudo systemctl stop rtpproxy.service
+        sudo systemctl status --no-pager rtpproxy.service || true
+        sudo systemctl disable --now rtpproxy.socket
+
     - name: Setup GitHub Actions artifact client
       uses: lhotari/gh-actions-artifact-client@v2
 

debian/changelog

@@ -22,6 +22,8 @@ rtpproxy (3.1+dev1) unstable; urgency=medium
     service runs under a locked-down account by default.
   * Align the packaged systemd unit with /run paths so PID tracking stays
     consistent with RuntimeDirectory management.
+  * Pass systemd's MAINPID through ExecStart so the daemon receives the
+    tracked PID even when launched under socket activation.
 
  -- Maxim Sobolev <[email protected]>  Wed, 15 May 2024 00:00:00 +0000
 

rpm/rtpproxy.service

@@ -11,7 +11,7 @@ EnvironmentFile=-/etc/sysconfig/rtpproxy
 PIDFile=/run/rtpproxy/rtpproxy.pid
 RuntimeDirectory=rtpproxy
 RuntimeDirectoryMode=0755
-ExecStart=/usr/bin/rtpproxy -f -s systemd: -p /run/rtpproxy/rtpproxy.pid $OPTIONS
+ExecStart=/usr/bin/rtpproxy -f -s systemd:$MAINPID -p /run/rtpproxy/rtpproxy.pid $OPTIONS
 ExecReload=/bin/kill -HUP $MAINPID
 Restart=on-failure