Ice candidates containing ::1 as IP is giving issues in 8.10 and 8.11

[helu-milestone]

Hey All

I've experienced that Ice Candidates containing ::1 cannot be used in 8.10 and 8.11 in 8.9 and down it works fine. If I change ::1 to localhost, the candidate works fine in all version, so I have a workaround.

Anyone know why ::1 is not working any longer? I havn't had time to check the changes in 8.10, this is more a question if someone have looked at this recently.

[sipsorcery]

When you say giving issues could you provide some more info or even better log messages?

I jsut added a couple of unit tests for the two representations of the IPv6 loopback address and the parsing looks fine so the problem seems to be elsewhere.

[helu-milestone]

Sorry for not being more specific. We didn't get any errors, but we saw weird behavior that. I only have our log, but I believe the IceConnectionState is behaving strange:

Adding candidate with ::1. IceConnectionState goes to state failed:

2025-04-23 08:16:31.020+02:00 [    18] DEBUG      - Initiating session for cameraId: d844c9a1-1c81-4dac-a3dd-0015c2609811 
2025-04-23 08:16:31.513+02:00 [     5] DEBUG      - GatheringState sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f, gathering 
2025-04-23 08:16:31.531+02:00 [     5] DEBUG      - OnServerIceCandidate sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f, 2327083705 1 udp 2113937663 10.10.17.20 49302 typ host generation 0 
2025-04-23 08:16:31.531+02:00 [     5] DEBUG      - GatheringState sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f, complete 
2025-04-23 08:16:31.531+02:00 [    18] DEBUG      - Session initiated for cameraId: d844c9a1-1c81-4dac-a3dd-0015c2609811 sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f streamId:   

2025-04-23 08:16:31.554+02:00 [     5] DEBUG      - ClientIceCandidate: sessionId b35fb5a7-786b-405a-94d4-e0d721dfdc1f - Added candidate - candidate: {"candidate":"candidate:929856940ip 1 udp 2113937152 ::1 49303 typ host generation 0","sdpMid":"0","sdpMLineIndex":0,"usernameFragment":"Yn2j"} 

2025-04-23 08:16:31.562+02:00 [     7] DEBUG      - Updating session for sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f - answerSDP: {"type":"answer","sdp":"v=0\r\no=- 5867195931974698194 3 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE 0 1\r\na=msid-semantic: WMS\r\nm=video 9 UDP/TLS/RTP/SAVP 101 103\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:Yn2j\r\na=ice-pwd:OyQACuwQSKvtbZzCwZ49JZJY\r\na=ice-options:trickle\r\na=fingerprint:sha-256 A7:3A:BC:BD:A1:34:58:DB:04:D7:A6:44:3B:49:28:F3:E1:6F:5D:E9:B0:E0:AD:37:36:E2:D2:26:BC:68:FC:72\r\na=setup:active\r\na=mid:0\r\na=recvonly\r\na=rtcp-mux\r\na=rtpmap:101 H264/90000\r\na=rtcp-fb:101 transport-cc\r\na=fmtp:101 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\na=rtpmap:103 H264/90000\r\na=rtcp-fb:103 transport-cc\r\na=fmtp:103 level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=42e01f\r\nm=application 9 UDP/DTLS/SCTP webrtc-datachannel\r\nc=IN IP4 0.0.0.0\r\na=ice-ufrag:Yn2j\r\na=ice-pwd:OyQACuwQSKvtbZzCwZ49JZJY\r\na=ice-options:trickle\r\na=fingerprint:sha-256 A7:3A:BC:BD:A1:34:58:DB:04:D7:A6:44:3B:49:28:F3:E1:6F:5D:E9:B0:E0:AD:37:36:E2:D2:26:BC:68:FC:72\r\na=setup:active\r\na=mid:1\r\na=sctp-port:5000\r\na=max-message-size:262144\r\n"}, token supplied: False 
2025-04-23 08:16:31.562+02:00 [     5] DEBUG      - ClientIceCandidate: sessionId b35fb5a7-786b-405a-94d4-e0d721dfdc1f - Added candidate - candidate: {"candidate":"candidate:929856940 1 udp 2113937151 a43d2e0a-ddc9-4141-a83c-3ba8ed28ded3.local 49303 typ host generation 1 ufrag Yn2j network-cost 999","sdpMid":"0","sdpMLineIndex":0,"usernameFragment":"Yn2j"} 
2025-04-23 08:16:31.562+02:00 [     7] DEBUG      - IceConnectionStateChanged sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f, checking 
2025-04-23 08:16:31.591+02:00 [     5] DEBUG      - Resolving mDNS address: a43d2e0a-ddc9-4141-a83c-3ba8ed28ded3.local 
2025-04-23 08:16:31.700+02:00 [     5] DEBUG      - Resolved mDNS address a43d2e0a-ddc9-4141-a83c-3ba8ed28ded3.local to 10.10.17.20 
2025-04-23 08:16:47.732+02:00 [     7] DEBUG      - IceConnectionStateChanged sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f, failed 
2025-04-23 08:16:47.732+02:00 [     7] DEBUG      - ConnectionStateChange sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f, failed 
2025-04-23 08:16:47.732+02:00 [     7] DEBUG      - Closing session: b35fb5a7-786b-405a-94d4-e0d721dfdc1f 
2025-04-23 08:16:47.732+02:00 [     7] DEBUG      - ConnectionStateChange sessionId: b35fb5a7-786b-405a-94d4-e0d721dfdc1f, closed 
2025-04-23 08:16:47.732+02:00 [     7] DEBUG      - Video source stopped 

Addiing candidate with IP 127.0.0.1:

2025-04-23 08:32:01.479+02:00 [    10] DEBUG      - Session initiated for cameraId: d844c9a1-1c81-4dac-a3dd-0015c2609811 sessionId: dcfe2d5f-3cbd-4159-b2e3-77cb88a420a5 streamId:   
2025-04-23 08:32:01.525+02:00 [     5] DEBUG      - Updating session for sessionId: dcfe2d5f-3cbd-4159-b2e3-77cb88a420a5 - answerSDP: {"type":"answer","sdp":"v=0\r\no=- 15204762948234067 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE 0 1\r\na=msid-semantic: WMS\r\nm=video 9 UDP/TLS/RTP/SAVP 101 103\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:c4TL\r\na=ice-pwd:KwiHUO98ipyXaRJOnxAtrR37\r\na=ice-options:trickle\r\na=fingerprint:sha-256 B3:5E:86:71:66:D1:DE:01:A9:04:99:CA:4F:A8:66:3A:FD:47:85:96:14:4E:13:2F:D2:76:F0:A8:99:61:ED:64\r\na=setup:active\r\na=mid:0\r\na=recvonly\r\na=rtcp-mux\r\na=rtpmap:101 H264/90000\r\na=rtcp-fb:101 transport-cc\r\na=fmtp:101 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\na=rtpmap:103 H264/90000\r\na=rtcp-fb:103 transport-cc\r\na=fmtp:103 level-asymmetry-allowed=1;packetization-mode=0;profile-level-id=42e01f\r\nm=application 9 UDP/DTLS/SCTP webrtc-datachannel\r\nc=IN IP4 0.0.0.0\r\na=ice-ufrag:c4TL\r\na=ice-pwd:KwiHUO98ipyXaRJOnxAtrR37\r\na=ice-options:trickle\r\na=fingerprint:sha-256 B3:5E:86:71:66:D1:DE:01:A9:04:99:CA:4F:A8:66:3A:FD:47:85:96:14:4E:13:2F:D2:76:F0:A8:99:61:ED:64\r\na=setup:active\r\na=mid:1\r\na=sctp-port:5000\r\na=max-message-size:262144\r\n"}, token supplied: False 

2025-04-23 08:32:01.540+02:00 [    18] DEBUG      - ClientIceCandidate: sessionId dcfe2d5f-3cbd-4159-b2e3-77cb88a420a5 - Added candidate - candidate: {"candidate":"candidate:2992428404ip 1 udp 2113937152 127.0.0.1 50462 typ host generation 0","sdpMid":"0","sdpMLineIndex":0,"usernameFragment":"c4TL"}

2025-04-23 08:32:01.540+02:00 [    18] DEBUG      - ClientIceCandidate: sessionId dcfe2d5f-3cbd-4159-b2e3-77cb88a420a5 - Added candidate - candidate: {"candidate":"candidate:2992428404 1 udp 2113937151 a43d2e0a-ddc9-4141-a83c-3ba8ed28ded3.local 50462 typ host generation 0 ufrag c4TL network-cost 999","sdpMid":"0","sdpMLineIndex":0,"usernameFragment":"c4TL"} 
2025-04-23 08:32:01.550+02:00 [     5] DEBUG      - IceConnectionStateChanged sessionId: dcfe2d5f-3cbd-4159-b2e3-77cb88a420a5, checking 
2025-04-23 08:32:01.602+02:00 [    18] DEBUG      - Resolving mDNS address: a43d2e0a-ddc9-4141-a83c-3ba8ed28ded3.local 
2025-04-23 08:32:01.618+02:00 [     5] DEBUG      - IceConnectionStateChanged sessionId: dcfe2d5f-3cbd-4159-b2e3-77cb88a420a5, connected 
2025-04-23 08:32:01.618+02:00 [     5] DEBUG      - ConnectionStateChange sessionId: dcfe2d5f-3cbd-4159-b2e3-77cb88a420a5, connecting 
2025-04-23 08:32:01.680+02:00 [    26] DEBUG      - ConnectionStateChange sessionId: dcfe2d5f-3cbd-4159-b2e3-77cb88a420a5, connected 
2025-04-23 08:32:01.724+02:00 [    18] DEBUG      - Resolved mDNS address a43d2e0a-ddc9-4141-a83c-3ba8ed28ded3.local to 10.10.17.20

I added line breaks at the important ice candidate. The only thing I've changed is to replace ::1 with 127.0.0.1 (initially I used localhost, but that was being ignored).

I also saw some difference, when I added breaks points around the area where we add ice candidates. Sometimes it would work with ::1. So it might be some kind of timing issue in our implementation. But when I remove ::1 there is no timing issue.

[ha-ves]

I read somewhere in the code that some platforms don't take dual-stack IP well, and some IPv4/6 mapping was used, I don't know if that's the case here.

[sipsorcery]

The logs don't show anything going wrong or right. What's needed are the ICE negotiation logs. Also useful to know what the otehr peer you're trying to connect to is? Browsers won't offerIPv4 or IPv6 loopback addresses and instead use the ,local hostnames.