[Hacker Rank] Warmup: Time Conversion solved ✅. SonarQube issues...

Author: Gonzalo Diaz

src/lib/exercises/src/hackerrank/warmup/time_conversion.c

@@ -9,7 +9,7 @@
 #include <string.h>
 
 char *HACKERRANK_WARMUP_firstN(const char *s, unsigned long n) {
-  unsigned long len = strlen(s);
+  unsigned long len = strlen_s(s);
   if (n > len) {
     return NULL;
   }
@@ -22,15 +22,15 @@ char *HACKERRANK_WARMUP_firstN(const char *s, unsigned long n) {
     return NULL;
   }
 
-  strncpy(result, s, n);
+  strncpy_s(result, s, n);
 
   result[n] = '\0';
 
   return result;
 }
 
 char *HACKERRANK_WARMUP_lastN(const char *s, unsigned long n) {
-  unsigned long len = strlen(s);
+  unsigned long len = strlen_s(s);
   if (n > len) {
     return NULL;
   }
@@ -43,7 +43,7 @@ char *HACKERRANK_WARMUP_lastN(const char *s, unsigned long n) {
     return NULL;
   }
 
-  strncpy(result, s + len - n, n);
+  strncpy_s(result, s + len - n, n);
 
   result[n] = '\0';
 
@@ -54,17 +54,18 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
   char *meridian = HACKERRANK_WARMUP_lastN(s, 2);
 
   char *hour_str = HACKERRANK_WARMUP_firstN(s, 2);
-  char *time_str = (char *)malloc((strlen(s) + 1) * sizeof(char));
+  char *time_str = (char *)malloc((strlen_s(s) + 1) * sizeof(char));
   if (time_str == NULL) {
     free(hour_str);
     free(meridian);
     return NULL;
   }
-  strcpy(time_str, s);
-  char *temp_time_str = HACKERRANK_WARMUP_lastN(time_str, strlen(time_str) - 2);
+  strcpy_s(time_str, s);
+  char *temp_time_str =
+      HACKERRANK_WARMUP_lastN(time_str, strlen_s(time_str) - 2);
   free(time_str);
   time_str = temp_time_str;
-  temp_time_str = HACKERRANK_WARMUP_firstN(time_str, strlen(time_str) - 2);
+  temp_time_str = HACKERRANK_WARMUP_firstN(time_str, strlen_s(time_str) - 2);
   free(time_str);
   time_str = temp_time_str;