[REFACTOR] [Hacker Rank] Warmup: Time Conversion solved ✅. Triying to fix sonarlint detected issues.

Author: Gonzalo Diaz

src/lib/exercises/src/hackerrank/warmup/time_conversion.c

@@ -8,27 +8,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-char *HACKERRANK_WARMUP_lastN(const char *s, unsigned long n) {
-  unsigned long len = strlen(s);
-  if (n > len) {
-    return NULL;
-  }
-  if (n == 0) {
-    return NULL;
-  }
-
-  char *result = (char *)malloc((n + 1) * sizeof(char));
-  if (result == NULL) {
-    return NULL;
-  }
-
-  strncpy(result, s + len - n, n);
-
-  result[n] = '\0';
-
-  return result;
-}
-
 char *HACKERRANK_WARMUP_getFirst(const char *s, unsigned long n) {
   return HACKERRANK_WARMUP_getStringFragment(s, strlen(s), 0, n);
 }
@@ -61,8 +40,8 @@ char *HACKERRANK_WARMUP_getStringFragment(const char *s, unsigned long len,
 }
 
 char *HACKERRANK_WARMUP_timeConversion(const char *s) {
-  char *meridian = HACKERRANK_WARMUP_lastN(s, 2);
-  // char *meridian = HACKERRANK_WARMUP_getLast(s, 2);
+  // char *meridian = HACKERRANK_WARMUP_lastN(s, 2);
+  char *meridian = HACKERRANK_WARMUP_getLast(s, 2);
 
   // char *hour_str = HACKERRANK_WARMUP_firstN(s, 2);
   char *hour_str = HACKERRANK_WARMUP_getFirst(s, 2);
@@ -76,7 +55,7 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
   strcpy(time_str, s);
   char *temp_time_str;
   unsigned long time_str_len = strlen(time_str);
-  temp_time_str = HACKERRANK_WARMUP_lastN(time_str, time_str_len - 2);
+  temp_time_str = HACKERRANK_WARMUP_getLast(time_str, time_str_len - 2);
   free(time_str);
   time_str = temp_time_str;
   temp_time_str = HACKERRANK_WARMUP_getFirst(time_str, time_str_len - 2);

src/tests/unit/lib/hackerrank/warmup/time_conversion.test.cpp

@@ -37,8 +37,8 @@ TEST_CASE("time_conversion helper functions edge cases",
   // CHECK(HACKERRANK_WARMUP_getFirst(nullptr, 0) == nullptr);
 
   CHECK(HACKERRANK_WARMUP_getFirst("", 10) == nullptr);
-  CHECK(HACKERRANK_WARMUP_lastN("", 10) == nullptr);
+  CHECK(HACKERRANK_WARMUP_getLast("", 10) == nullptr);
 
   CHECK(HACKERRANK_WARMUP_getFirst("", 0) == nullptr);
-  CHECK(HACKERRANK_WARMUP_lastN("", 0) == nullptr);
+  CHECK(HACKERRANK_WARMUP_getLast("", 0) == nullptr);
 }