[REFACTOR] [Hacker Rank] Warmup: Time Conversion solved ✅. Triying to fix sonarlint detected issues.

Author: Gonzalo Diaz

src/lib/exercises/src/hackerrank/warmup/time_conversion.c

@@ -47,21 +47,24 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
   char *meridian = HACKERRANK_WARMUP_getLast(s, 2);
   char *hour_str = HACKERRANK_WARMUP_getFirst(s, 2);
 
-  char *time_str = malloc(strlen(s) + 1);
+  size_t s_len = strlen(s);
+  char *time_str = malloc(s_len + 1);
   if (time_str == NULL) {
     free(meridian);
     free(hour_str);
     return NULL;
   }
 
-  strcpy(time_str, s);
+  strncpy(time_str, s, s_len + 1);
   char *temp_time_str;
   unsigned long time_str_len = strlen(time_str);
   temp_time_str = HACKERRANK_WARMUP_getLast(time_str, time_str_len - 2);
-  strcpy(time_str, temp_time_str);
+  strncpy(time_str, temp_time_str, time_str_len - 2);
+  time_str[time_str_len - 2] = '\0';
   free(temp_time_str);
   temp_time_str = HACKERRANK_WARMUP_getFirst(time_str, time_str_len - 2);
-  strcpy(time_str, temp_time_str);
+  strncpy(time_str, temp_time_str, time_str_len - 2);
+  time_str[time_str_len - 2] = '\0';
   free(temp_time_str);
 
   char *endptr;