[REFACTOR] [Hacker Rank] Warmup: Time Conversion solved ✅. Triying to fix sonarlint detected issues.

Author: Gonzalo Diaz

src/lib/exercises/src/hackerrank/warmup/time_conversion.c

@@ -8,8 +8,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-#define TIME_SIZE 11 // hh:mm:ssXX 10 + 1 for null terminator
-
 char *HACKERRANK_WARMUP_getFirst(const char *s, unsigned long n) {
   return HACKERRANK_WARMUP_getStringFragment(s, strlen(s), 0, n);
 }
@@ -49,7 +47,8 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
   char *meridian = HACKERRANK_WARMUP_getLast(s, 2);
   char *hour_str = HACKERRANK_WARMUP_getFirst(s, 2);
 
-  char time_str[TIME_SIZE];
+  char *time_str = malloc(strlen(s) + 1);
+
   strcpy(time_str, s);
   char *temp_time_str;
   unsigned long time_str_len = strlen(time_str);
@@ -66,8 +65,9 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
   if (*endptr != '\0') {
     printf("Conversion error, non-convertible part: %s\n", endptr);
 
-    free(hour_str);
     free(meridian);
+    free(hour_str);
+    free(time_str);
     free(endptr);
     return NULL;
   } else {
@@ -87,6 +87,7 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
   snprintf(conversion, BUFFER_MAX_SIZE, "%02ld%s", hour, time_str);
   free(hour_str);
   free(meridian);
+  free(time_str);
 
   return conversion;
 }