[REFACTOR] [Hacker Rank] Warmup: Time Conversion solved ✅. Triying to fix sonarlint detected issues.

Gonzalo Diaz · Gonzalo Diaz · commit f6d4792cefce · 2025-01-15T18:37:34.000-03:00
diff --git a/src/lib/exercises/src/hackerrank/warmup/time_conversion.c b/src/lib/exercises/src/hackerrank/warmup/time_conversion.c
@@ -8,6 +8,8 @@
 #include <stdlib.h>
 #include <string.h>
 
+const unsigned int TIME_SIZE = 11; // hh:mm:ssXX 10 + 1 for null terminator
+
 char *HACKERRANK_WARMUP_getFirst(const char *s, unsigned long n) {
   return HACKERRANK_WARMUP_getStringFragment(s, strlen(s), 0, n);
 }
@@ -44,8 +46,6 @@ char *HACKERRANK_WARMUP_timeConversion(const char *s) {
     return NULL;
   }
 
-  const unsigned int TIME_SIZE = 11; // hh:mm:ssXX 10 + 1 for null terminator
-
   char *meridian = HACKERRANK_WARMUP_getLast(s, 2);
   char *hour_str = HACKERRANK_WARMUP_getFirst(s, 2);
 

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,8 @@`
`8`	`8`	`#include <stdlib.h>`
`9`	`9`	`#include <string.h>`
`10`	`10`
	`11`	`+const unsigned int TIME_SIZE = 11; // hh:mm:ssXX 10 + 1 for null terminator`
	`12`	`+`
`11`	`13`	`char HACKERRANK_WARMUP_getFirst(const char s, unsigned long n) {`
`12`	`14`	`return HACKERRANK_WARMUP_getStringFragment(s, strlen(s), 0, n);`
`13`	`15`	`}`
`@@ -44,8 +46,6 @@ char HACKERRANK_WARMUP_timeConversion(const char s) {`
`44`	`46`	`return NULL;`
`45`	`47`	`}`
`46`	`48`
`47`		`- const unsigned int TIME_SIZE = 11; // hh:mm:ssXX 10 + 1 for null terminator`
`48`		`-`
`49`	`49`	`char *meridian = HACKERRANK_WARMUP_getLast(s, 2);`
`50`	`50`	`char *hour_str = HACKERRANK_WARMUP_getFirst(s, 2);`
`51`	`51`