[REFACTOR] [Hacker Rank] Warmup: Time Conversion solved ✅. Trying to solve sonarcloud warnings.

Author: Gonzalo Diaz

src/lib/exercises/src/hackerrank/warmup/time_conversion.c

@@ -12,10 +12,12 @@
 
 char *HACKERRANK_WARMUP_getFirst(const char *s, unsigned long n) {
   char dest[HACKERRANK_WARMUP_MAX_STRING_SIZE + 1];
-  strncpy(dest, s, sizeof dest);
   dest[sizeof dest - 1] = 0;
+  strncpy(dest, s, sizeof dest);
+  if (dest[sizeof dest - 1] != 0) {
+    return NULL; // Handle error
+  }
   size_t s_len = strlen(s);
-  strlen(dest);
 
   return HACKERRANK_WARMUP_getStringFragment(s, s_len, 0, n);
 }