Skip to content

Commit 742d079

Browse files
author
Markus Fleischauer
committed
add builder default annotations where needed and fix some other obvious build warning.
1 parent 7e4e54c commit 742d079

File tree

5 files changed

+3
-6
lines changed
  • chemical_db_oss/src/main/java/de/unijena/bioinf/spectraldb/entities
  • fragmentation_tree/fragmentation_tree_construction/src/main/java/de/unijena/bioinf/FragmentationTreeConstruction/computation/recalibration
  • lcms2/src/main/java/de/unijena/bioinf/lcms/statistics
  • sirius_gui/src/main/java/de/unijena/bioinf/ms/gui/utils/loading
  • sirius_rest_service/src/main/java/de/unijena/bioinf/ms/middleware/service/projects

5 files changed

+3
-6
lines changed

chemical_db_oss/src/main/java/de/unijena/bioinf/spectraldb/entities/Ms2ReferenceSpectrum.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ public class Ms2ReferenceSpectrum implements ReferenceSpectrum {
7070
*/
7171
private double exactMass;
7272

73+
@Builder.Default
7374
private int msLevel = 0;
7475

7576
/**

fragmentation_tree/fragmentation_tree_construction/src/main/java/de/unijena/bioinf/FragmentationTreeConstruction/computation/recalibration/MedianSlope.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public double[][] getMedianSubsetFairDistributed(final Spectrum<Peak> measured,
9797
Collections.sort(chosenPeaks[k], new Comparator<Integer>() {
9898
@Override
9999
public int compare(Integer o1, Integer o2) {
100-
return new Double(measured.getIntensityAt(o2)).compareTo(measured.getIntensityAt(o1));
100+
return Double.compare(measured.getIntensityAt(o2), measured.getIntensityAt(o1));
101101
}
102102
});
103103
}

lcms2/src/main/java/de/unijena/bioinf/lcms/statistics/SampleStats.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ public float ms2NoiseLevel() {
5050
return ms2NoiseLevel;
5151
}
5252

53+
@Builder.Default
5354
private double expectedPeakWidth = -1;
5455

5556
public Optional<Double> getExpectedPeakWidth() {

sirius_gui/src/main/java/de/unijena/bioinf/ms/gui/utils/loading/SiriusCardLayout.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -179,10 +179,6 @@ public void addLayoutComponent(Component comp, Object constraints) {
179179
}
180180
}
181181

182-
/**
183-
* @deprecated replaced by
184-
* {@code addLayoutComponent(Component, Object)}.
185-
*/
186182
public void addLayoutComponent(String name, Component comp) {
187183
synchronized (comp.getTreeLock()) {
188184
if (!vector.isEmpty()) {

sirius_rest_service/src/main/java/de/unijena/bioinf/ms/middleware/service/projects/Project.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ default Compound findCompoundById(String compoundId, Compound.OptField... optFie
8888
EnumSet.of(AlignedFeature.OptField.topAnnotations));
8989
}
9090

91-
@SneakyThrows
9291
Compound findCompoundById(String compoundId, boolean msDataSearchPrepared, @NotNull EnumSet<Compound.OptField> optFields, @NotNull EnumSet<AlignedFeature.OptField> optFeatureFields);
9392

9493
void deleteCompoundById(String compoundId);

0 commit comments

Comments
 (0)