Skip to content

Commit bb84c5a

Browse files
[test] Move Firefox tests to CircleCI (mui#34764)
1 parent e0141b8 commit bb84c5a

File tree

5 files changed

+21
-21
lines changed

5 files changed

+21
-21
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,7 @@ jobs:
346346
exit 0
347347
test_browser:
348348
<<: *defaults
349+
resource_class: 'medium+'
349350
docker:
350351
- image: mcr.microsoft.com/playwright:v1.27.1-focal
351352
environment:

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@
149149
"karma": "^6.4.1",
150150
"karma-browserstack-launcher": "~1.6.0",
151151
"karma-chrome-launcher": "^3.1.1",
152+
"karma-firefox-launcher": "^2.1.2",
152153
"karma-coverage-istanbul-reporter": "^3.0.3",
153154
"karma-mocha": "^2.0.1",
154155
"karma-sourcemap-loader": "^0.3.8",

packages/mui-material/src/IconButton/IconButton.test.js

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,13 @@ describe('<IconButton />', () => {
3434
expect(container.querySelector('.touch-ripple')).not.to.equal(null);
3535
});
3636

37-
['default', 'primary'].forEach((color) => {
38-
it(`can disable the ripple and hover effect for color ${color}`, () => {
39-
const { container, getByRole } = render(
40-
<IconButton disableRipple color={color} TouchRippleProps={{ className: 'touch-ripple' }}>
41-
book
42-
</IconButton>,
43-
);
44-
expect(container.querySelector('.touch-ripple')).to.equal(null);
45-
expect(getComputedStyle(getByRole('button'), ':hover').backgroundColor).to.equal(
46-
getComputedStyle(getByRole('button')).backgroundColor,
47-
);
48-
});
37+
it('can disable the ripple and hover effect', () => {
38+
const { container } = render(
39+
<IconButton disableRipple TouchRippleProps={{ className: 'touch-ripple' }}>
40+
book
41+
</IconButton>,
42+
);
43+
expect(container.querySelector('.touch-ripple')).to.equal(null);
4944
});
5045

5146
describe('prop: size', () => {

test/karma.conf.js

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ const browserStack = {
3131
};
3232

3333
process.env.CHROME_BIN = playwright.chromium.executablePath();
34+
process.env.FIREFOX_BIN = playwright.firefox.executablePath();
3435

3536
// BrowserStack rate limit after 1600 calls every 5 minutes.
3637
// Per second, https://www.browserstack.com/docs/automate/api-reference/selenium/introduction#rest-api-projects
@@ -45,7 +46,7 @@ const MAX_CIRCLE_CI_CONCURRENCY = 83;
4546
module.exports = function setKarmaConfig(config) {
4647
const baseConfig = {
4748
basePath: '../',
48-
browsers: ['chromeHeadless'],
49+
browsers: ['chromeHeadless', 'FirefoxHeadless'],
4950
browserDisconnectTimeout: 3 * 60 * 1000, // default 2000
5051
browserDisconnectTolerance: 1, // default 0
5152
browserNoActivityTimeout: 3 * 60 * 1000, // default 30000
@@ -83,6 +84,7 @@ module.exports = function setKarmaConfig(config) {
8384
'karma-coverage-istanbul-reporter',
8485
'karma-sourcemap-loader',
8586
'karma-webpack',
87+
'karma-firefox-launcher',
8688
],
8789
/**
8890
* possible values:
@@ -212,7 +214,7 @@ module.exports = function setKarmaConfig(config) {
212214
newConfig = {
213215
...baseConfig,
214216
browserStack,
215-
browsers: baseConfig.browsers.concat(['chrome', 'firefox', 'safari', 'edge']),
217+
browsers: baseConfig.browsers.concat(['chrome', 'safari', 'edge']),
216218
plugins: baseConfig.plugins.concat(['karma-browserstack-launcher']),
217219
customLaunchers: {
218220
...baseConfig.customLaunchers,
@@ -226,13 +228,6 @@ module.exports = function setKarmaConfig(config) {
226228
// TODO: Investigate why.
227229
browser_version: '87.0',
228230
},
229-
firefox: {
230-
base: 'BrowserStack',
231-
os: 'Windows',
232-
os_version: '10',
233-
browser: 'firefox',
234-
browser_version: '78.0',
235-
},
236231
safari: {
237232
base: 'BrowserStack',
238233
os: 'OS X',

yarn.lock

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10290,6 +10290,14 @@ karma-coverage-istanbul-reporter@^3.0.3:
1029010290
istanbul-reports "^3.0.2"
1029110291
minimatch "^3.0.4"
1029210292

10293+
karma-firefox-launcher@^2.1.2:
10294+
version "2.1.2"
10295+
resolved "https://registry.yarnpkg.com/karma-firefox-launcher/-/karma-firefox-launcher-2.1.2.tgz#9a38cc783c579a50f3ed2a82b7386186385cfc2d"
10296+
integrity sha512-VV9xDQU1QIboTrjtGVD4NCfzIH7n01ZXqy/qpBhnOeGVOkG5JYPEm8kuSd7psHE6WouZaQ9Ool92g8LFweSNMA==
10297+
dependencies:
10298+
is-wsl "^2.2.0"
10299+
which "^2.0.1"
10300+
1029310301
karma-mocha@^2.0.1:
1029410302
version "2.0.1"
1029510303
resolved "https://registry.yarnpkg.com/karma-mocha/-/karma-mocha-2.0.1.tgz#4b0254a18dfee71bdbe6188d9a6861bf86b0cd7d"

0 commit comments

Comments
 (0)