fix: suppress S5659 via NOSONAR and rename remaining test functions

- Add NOSONAR inline comment for ParseUnverified (go:S5659) since
  sonar.issue.ignore.multicriteria is not honored by Automatic Analysis
- Rename TestNewVerifier_MissingTrustEvaluator -> TestNewVerifierMissingTrustEvaluator
- Rename TestNewMDocHandler_WithTrustEvaluator -> TestNewMDocHandlerWithTrustEvaluator

Author: leifj

internal/verifier/apiv1/handlers_verification.go

@@ -430,7 +430,7 @@ func (c *Client) evaluateIssuerTrust(ctx context.Context, vpToken string, scope
 	// signature verification is performed below by verifyJWTSignature() which enforces
 	// a strict algorithm allowlist and rejects "none" and other weak algorithms.
 	parser := jwt.NewParser(jwt.WithoutClaimsValidation())
-	token, _, err := parser.ParseUnverified(issuerJWT, jwt.MapClaims{})
+	token, _, err := parser.ParseUnverified(issuerJWT, jwt.MapClaims{}) // NOSONAR (go:S5659) - ParseUnverified is intentional; signature is verified below by verifyJWTSignature()
 	if err != nil {
 		return fmt.Errorf("failed to parse JWT header: %w", err)
 	}

pkg/mdoc/verifier_test.go

@@ -186,7 +186,7 @@ func TestNewVerifier(t *testing.T) {
 	}
 }
 
-func TestNewVerifier_MissingTrustEvaluator(t *testing.T) {
+func TestNewVerifierMissingTrustEvaluator(t *testing.T) {
 	_, err := NewVerifier(VerifierConfig{})
 
 	if err == nil {

pkg/openid4vp/mdoc_handler_test.go

@@ -44,7 +44,7 @@ func TestNewMDocHandler(t *testing.T) {
 	}
 }
 
-func TestNewMDocHandler_WithTrustEvaluator(t *testing.T) {
+func TestNewMDocHandlerWithTrustEvaluator(t *testing.T) {
 	te := &mockTrustEvaluator{trusted: true}
 
 	h, err := NewMDocHandler(WithMDocTrustEvaluator(te))