Fix bug with meta tags with content attribute

sirreal · sirreal · commit b16e814a03d0 · 2024-09-05T18:39:49.000+02:00
Meta tags with non-empty `content` attribute would confuse the script
and attempt to treat the content string as a Template.content tree.
diff --git a/html-api-debugger/print-html-tree.js b/html-api-debugger/print-html-tree.js
@@ -172,7 +172,10 @@ export function printHtmlApiTree(node, ul, options = {}) {
 			}
 		}
 
-		if (node.childNodes[i].childNodes?.length || node.childNodes[i].content) {
+		if (
+			node.childNodes[i].childNodes?.length ||
+			(node.childNodes[i].nodeName === 'TEMPLATE' && node.childNodes[i].content)
+		) {
 			const next = node.childNodes[i].childNodes?.length
 				? node.childNodes[i]
 				: node.childNodes[i].content;
diff --git a/html-api-debugger/readme.txt b/html-api-debugger/readme.txt
@@ -77,3 +77,4 @@ Add a page to wp-admin for debugging the HTML API.
 
 = 1.6 =
 * Replace TABLE based layout with CSS grid.
+* Fix a crash on meta tags with a content attribute.

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,10 @@ export function printHtmlApiTree(node, ul, options = {}) {`
`172`	`172`	`}`
`173`	`173`	`}`
`174`	`174`
`175`		`- if (node.childNodes[i].childNodes?.length \|\| node.childNodes[i].content) {`
	`175`	`+ if (`
	`176`	`+ node.childNodes[i].childNodes?.length \|\|`
	`177`	`+ (node.childNodes[i].nodeName === 'TEMPLATE' && node.childNodes[i].content)`
	`178`	`+ ) {`
`176`	`179`	`const next = node.childNodes[i].childNodes?.length`
`177`	`180`	`? node.childNodes[i]`
`178`	`181`	`: node.childNodes[i].content;`
Original file line number	Diff line number	Diff line change
`@@ -77,3 +77,4 @@ Add a page to wp-admin for debugging the HTML API.`
`77`	`77`
`78`	`78`	`= 1.6 =`
`79`	`79`	`* Replace TABLE based layout with CSS grid.`
	`80`	`+* Fix a crash on meta tags with a content attribute.`