Skip to content

Commit 43b6b77

Browse files
committed
Build/Test Tools: Temporarily ignore Slack failures.
When many workflows are initiated at the same time, there are often instances where the requests to Slack providing updates are rate limited. This usually happens when the Test Old Branches workflow runs and initiates testing for all workflows in branches that could potentially receive a security update. Even though everything was successful in the workflow except the message, the workflow run is marked as failed. The next time the same workflow runs for that branch, a “fixed” message will be sent to `#core` in Slack. The result is a burst of messages that is quite noisy and unnecessary. This temporarily adds `continue-on-error` to the jobs responsible for sending the messages until a better solution can be decided on. See #61701. git-svn-id: https://develop.svn.wordpress.org/trunk@59209 602fd350-edb4-49c9-b593-d223f7449a82
1 parent f2a4205 commit 43b6b77

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/slack-notifications.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ jobs:
161161
failure:
162162
name: Failure notifications
163163
runs-on: ubuntu-latest
164+
continue-on-error: true
164165
timeout-minutes: 5
165166
needs: [ prepare ]
166167
if: ${{ needs.prepare.outputs.previous_conclusion != 'first-failure' && inputs.calling_status == 'failure' || failure() }}
@@ -177,6 +178,7 @@ jobs:
177178
fixed:
178179
name: Fixed notifications
179180
runs-on: ubuntu-latest
181+
continue-on-error: true
180182
timeout-minutes: 5
181183
needs: [ prepare ]
182184
if: ${{ contains( fromJson( '["failure", "cancelled", "none"]' ), needs.prepare.outputs.previous_conclusion ) && inputs.calling_status == 'success' && success() }}
@@ -193,6 +195,7 @@ jobs:
193195
success:
194196
name: Success notifications
195197
runs-on: ubuntu-latest
198+
continue-on-error: true
196199
timeout-minutes: 5
197200
needs: [ prepare ]
198201
if: ${{ inputs.calling_status == 'success' && success() }}
@@ -209,6 +212,7 @@ jobs:
209212
cancelled:
210213
name: Cancelled notifications
211214
runs-on: ubuntu-latest
215+
continue-on-error: true
212216
timeout-minutes: 5
213217
needs: [ prepare ]
214218
if: ${{ inputs.calling_status == 'cancelled' || cancelled() }}

0 commit comments

Comments
 (0)