Skip to content

Commit 4e9f7fb

Browse files
committed
Add and improve tests
1 parent 67250a0 commit 4e9f7fb

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tests/phpunit/tests/html-api/wpHtmlTagProcessorModifiableText.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ public static function data_unallowed_modifiable_text_updates() {
511511
* @param string $update Update containing possibly-compromising text.
512512
* @param string $expected Expected result.
513513
*/
514-
public function test_safely_updates_dangerous_javascript_script_tag_contents( string $html, string $update, string $expected ) {
514+
public function test_safely_updates_dangerous_JavaScript_script_tag_contents( string $html, string $update, string $expected ) {
515515
$processor = new WP_HTML_Tag_Processor( $html );
516516
$this->assertTrue( $processor->next_tag( 'SCRIPT' ) );
517517
$this->assertTrue( $processor->set_modifiable_text( $update ) );
@@ -526,12 +526,16 @@ public function test_safely_updates_dangerous_javascript_script_tag_contents( st
526526
public static function data_script_tag_text_updates(): array {
527527
return array(
528528
'Simple update' => array( '<script></script>', '{}', '<script>{}</script>' ),
529+
'Needs no replacement' => array( '<script></script>', '<!--<scriptish>', '<script><!--<scriptish></script>' ),
529530
'var script;1<script>0' => array( '<script></script>', 'var script;1<script>0', '<script>var script;1<\u0073cript>0</script>' ),
530531
'1</script>/' => array( '<script></script>', '1</script>/', '<script>1</\u0073cript>/</script>' ),
531532
'var SCRIPT;1<SCRIPT>0' => array( '<script></script>', 'var SCRIPT;1<SCRIPT>0', '<script>var SCRIPT;1<\u0053CRIPT>0</script>' ),
532533
'1</SCRIPT>/' => array( '<script></script>', '1</SCRIPT>/', '<script>1</\u0053CRIPT>/</script>' ),
533534
'"</script>"' => array( '<script></script>', '"</script>"', '<script>"</\u0073cript>"</script>' ),
534535
'"</ScRiPt>"' => array( '<script></script>', '"</ScRiPt>"', '<script>"</\u0053cRiPt>"</script>' ),
536+
'Module tag' => array( '<script type="module"></script>', '"<script>"', '<script type="module">"<\u0073cript>"</script>' ),
537+
'Tag with type' => array( '<script type="text/javascript"></script>', '"<script>"', '<script type="text/javascript">"<\u0073cript>"</script>' ),
538+
'Tag with language' => array( '<script language="javascript"></script>', '"<script>"', '<script language="javascript">"<\u0073cript>"</script>' ),
535539
);
536540
}
537541
}

0 commit comments

Comments
 (0)