Users: Throw specific warning when wp_insert_user() called without user_pass.

Modifies `wp_insert_user()` to throw the warning `The user_pass field is required when creating a new user. The user will need to reset their password before logging in.` when called without the `user_pass` argument defined.

This avoids a mix of warnings being thrown depending on the version of PHP the system is running on, anywhere between zero and three.

To retain backward compatibility the user is created with an empty password. As WordPress does not accept an empty password during authentication, this will require the newly created user complete the password reset process.

Props dd32, hbhalodia, iamadisingh, mindctrl, rollybueno, sheldorofazeroth, shilpaashokan94
Fixes #63770.


git-svn-id: https://develop.svn.wordpress.org/trunk@60650 602fd350-edb4-49c9-b593-d223f7449a82

Author: peterwilsoncc

src/wp-includes/user.php

@@ -2221,6 +2221,18 @@ function wp_insert_user( $userdata ) {
 		$user_pass = ! empty( $userdata['user_pass'] ) ? $userdata['user_pass'] : $old_user_data->user_pass;
 	} else {
 		$update = false;
+
+		if ( empty( $userdata['user_pass'] ) ) {
+			wp_trigger_error(
+				__FUNCTION__,
+				__( 'The user_pass field is required when creating a new user. The user will need to reset their password before logging in.' ),
+				E_USER_WARNING
+			);
+
+			// Set the password as an empty string to force the password reset flow.
+			$userdata['user_pass'] = '';
+		}
+
 		// Hash the password.
 		$user_pass = wp_hash_password( $userdata['user_pass'] );
 	}

tests/phpunit/tests/user/slashes.php

@@ -154,7 +154,7 @@ public function test_wp_insert_user() {
 				'nickname'     => self::SLASH_5,
 				'display_name' => self::SLASH_7,
 				'description'  => self::SLASH_3,
-				'user_pass'    => '',
+				'user_pass'    => 'password',
 			)
 		);
 		$user    = get_user_to_edit( $user_id );
@@ -175,7 +175,7 @@ public function test_wp_insert_user() {
 				'nickname'     => self::SLASH_6,
 				'display_name' => self::SLASH_2,
 				'description'  => self::SLASH_4,
-				'user_pass'    => '',
+				'user_pass'    => 'password',
 			)
 		);
 		$user    = get_user_to_edit( $user_id );