HTML API: Use assertEqualHTML() in wp_rel_ugc() tests.

dmsnell · dmsnell · commit 6f60f80be094 · 2025-07-18T20:57:41.000Z
In some tests, the expected output was updated to its pure HTML state, removing the wrapping call to `wp_slash()`. Instead, `stripslashes()` has been applied to the output of the code under function. This leaves more readable test failures. Developed in WordPress#9255 Discussed in https://core.trac.wordpress.org/ticket/63694 Props dmsnell, jonsurrell. See #63694. git-svn-id: https://develop.svn.wordpress.org/trunk@60485 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/tests/phpunit/tests/comment.php b/tests/phpunit/tests/comment.php
@@ -168,7 +168,7 @@ public function test_update_comment_from_unprivileged_user_by_privileged_user()
 		wp_set_current_user( 0 );
 
 		$comment = get_comment( $comment_id );
-		$this->assertSame( '<a href="http://example.localhost/something.html" rel="nofollow ugc">click</a>', $comment->comment_content, 'Comment: ' . $comment->comment_content );
+		$this->assertEqualHTML( '<a href="http://example.localhost/something.html" rel="nofollow ugc">click</a>', $comment->comment_content, '<body>', 'Comment: ' . $comment->comment_content );
 	}
 
 	/**
diff --git a/tests/phpunit/tests/formatting/wpRelUgc.php b/tests/phpunit/tests/formatting/wpRelUgc.php
@@ -12,25 +12,25 @@ class Tests_Formatting_wpRelUgc extends WP_UnitTestCase {
 	 */
 	public function test_add_ugc() {
 		$content  = '<p>This is some cool <a href="/">Code</a></p>';
-		$expected = '<p>This is some cool <a href=\"/\" rel=\"nofollow ugc\">Code</a></p>';
-		$this->assertSame( $expected, wp_rel_ugc( $content ) );
+		$expected = '<p>This is some cool <a href="/" rel="nofollow ugc">Code</a></p>';
+		$this->assertEqualHTML( $expected, stripslashes( wp_rel_ugc( $content ) ) );
 	}
 
 	/**
 	 * @ticket 48022
 	 */
 	public function test_convert_ugc() {
 		$content  = '<p>This is some cool <a href="/" rel="weird">Code</a></p>';
-		$expected = '<p>This is some cool <a href=\"/\" rel=\"weird nofollow ugc\">Code</a></p>';
-		$this->assertSame( $expected, wp_rel_ugc( $content ) );
+		$expected = '<p>This is some cool <a href="/" rel="weird nofollow ugc">Code</a></p>';
+		$this->assertEqualHTML( $expected, stripslashes( wp_rel_ugc( $content ) ) );
 	}
 
 	/**
 	 * @ticket 48022
 	 * @dataProvider data_wp_rel_ugc
 	 */
 	public function test_wp_rel_ugc( $input, $output, $expect_deprecation = false ) {
-		$this->assertSame( wp_slash( $output ), wp_rel_ugc( $input ) );
+		$this->assertEqualHTML( $output, stripslashes( wp_rel_ugc( $input ) ) );
 	}
 
 	public function data_wp_rel_ugc() {
@@ -81,7 +81,7 @@ public function data_wp_rel_ugc() {
 	public function test_append_ugc_with_valueless_attribute() {
 
 		$content  = '<p>This is some cool <a href="demo.com" download rel="hola">Code</a></p>';
-		$expected = '<p>This is some cool <a href=\"demo.com\" download rel=\"hola nofollow ugc\">Code</a></p>';
-		$this->assertSame( $expected, wp_rel_ugc( $content ) );
+		$expected = '<p>This is some cool <a href="demo.com" download rel="hola nofollow ugc">Code</a></p>';
+		$this->assertEqualHTML( $expected, stripslashes( wp_rel_ugc( $content ) ) );
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ public function test_update_comment_from_unprivileged_user_by_privileged_user()`
`168`	`168`	`wp_set_current_user( 0 );`
`169`	`169`
`170`	`170`	`$comment = get_comment( $comment_id );`
`171`		`- $this->assertSame( '<a href="http://example.localhost/something.html" rel="nofollow ugc">click</a>', $comment->comment_content, 'Comment: ' . $comment->comment_content );`
	`171`	`+ $this->assertEqualHTML( '<a href="http://example.localhost/something.html" rel="nofollow ugc">click</a>', $comment->comment_content, '<body>', 'Comment: ' . $comment->comment_content );`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`/**`