Skip to content

Commit c697356

Browse files
committed
Build/Test Tools: Document every matrix exclusion.
There should be inline documentation anytime a strategy matrix has an `exclude` combination configured so that contributors have proper context as to why it’s there. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59531 602fd350-edb4-49c9-b593-d223f7449a82
1 parent 8ed4cae commit c697356

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

.github/workflows/install-testing.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,19 @@ jobs:
7878

7979
# Exclude some PHP and MySQL versions that cannot currently be tested with Docker containers.
8080
exclude:
81+
# There are no local WordPress Docker environment containers for PHP <= 5.3.
8182
- php: '5.2'
8283
- php: '5.3'
84+
# MySQL containers <= 5.5 do not exist or fail to start properly.
8385
- db-version: '5.0'
8486
- db-version: '5.1'
8587
- db-version: '5.5'
88+
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
8689
- php: '7.2'
8790
db-version: '8.4'
8891
- php: '7.3'
8992
db-version: '8.4'
93+
# MySQL 9.0+ will not work on PHP 7.2 & 7.3. See https://core.trac.wordpress.org/ticket/61218.
9094
- php: '7.2'
9195
db-version: '9.0'
9296
- php: '7.3'

.github/workflows/local-docker-environment.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ jobs:
8888
db-version: ${{ fromJSON( needs.build-test-matrix.outputs.mysql-versions ) }}
8989

9090
exclude:
91-
# The MySQL 5.5 containers will not start.
91+
# MySQL containers <= 5.5 do not exist or fail to start properly.
9292
- db-version: '5.5'
93-
# MySQL 9.0+ will not work on PHP 7.2 & 7.3
93+
# MySQL 9.0+ will not work on PHP 7.2 & 7.3. See https://core.trac.wordpress.org/ticket/61218.
9494
- php: '7.2'
9595
db-version: '9.0'
9696
- php: '7.3'

.github/workflows/phpunit-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ jobs:
9393
report: true
9494

9595
exclude:
96-
# MySQL 9.0+ will not work on PHP 7.2 & 7.3
96+
# MySQL 9.0+ will not work on PHP 7.2 & 7.3. See https://core.trac.wordpress.org/ticket/61218.
9797
- php: '7.2'
9898
db-version: '9.0'
9999
- php: '7.3'

.github/workflows/upgrade-testing.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,12 @@ jobs:
7272
multisite: [ false, true ]
7373

7474
exclude:
75+
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
7576
- php: '7.2'
7677
db-version: '8.4'
7778
- php: '7.3'
7879
db-version: '8.4'
79-
# MySQL 9.0+ will not work on PHP 7.2 & 7.3
80+
# MySQL 9.0+ will not work on PHP 7.2 & 7.3. See https://core.trac.wordpress.org/ticket/61218.
8081
- php: '7.2'
8182
db-version: '9.1'
8283
- php: '7.3'
@@ -108,6 +109,7 @@ jobs:
108109
multisite: [ false, true ]
109110

110111
exclude:
112+
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
111113
- php: '7.2'
112114
db-version: '8.4'
113115
- php: '7.3'
@@ -137,6 +139,7 @@ jobs:
137139
multisite: [ false, true ]
138140

139141
exclude:
142+
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
140143
- php: '7.2'
141144
db-version: '8.4'
142145
- php: '7.3'
@@ -195,6 +198,7 @@ jobs:
195198
multisite: [ false, true ]
196199

197200
exclude:
201+
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
198202
- php: '7.2'
199203
db-version: '8.4'
200204
- php: '7.3'
@@ -254,11 +258,12 @@ jobs:
254258
multisite: [ false, true ]
255259

256260
exclude:
261+
# The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218.
257262
- php: '7.2'
258263
db-version: '8.4'
259264
- php: '7.3'
260265
db-version: '8.4'
261-
# MySQL 9.0+ will not work on PHP 7.2 & 7.3
266+
# MySQL 9.0+ will not work on PHP 7.2 & 7.3. See https://core.trac.wordpress.org/ticket/61218.
262267
- php: '7.2'
263268
db-version: '9.1'
264269
- php: '7.3'

0 commit comments

Comments
 (0)