Fix logic bug in child selector exploration

sirreal · sirreal · commit d42e53f0568d · 2024-12-05T14:51:59.000+01:00
diff --git a/src/wp-includes/html-api/class-wp-css-complex-selector.php b/src/wp-includes/html-api/class-wp-css-complex-selector.php
@@ -46,7 +46,7 @@ private function explore_matches( array $selectors, array $breadcrumbs ): bool {
 				if ( '*' === $selector->type_selector->ident || strcasecmp( $breadcrumbs[0], $selector->type_selector->ident ) === 0 ) {
 					return $this->explore_matches( array_slice( $selectors, 2 ), array_slice( $breadcrumbs, 1 ) );
 				}
-				return $this->explore_matches( $selectors, array_slice( $breadcrumbs, 1 ) );
+				return false;
 
 			case self::COMBINATOR_DESCENDANT:
 				// Find _all_ the breadcrumbs that match and recurse from each of them.

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ private function explore_matches( array $selectors, array $breadcrumbs ): bool {`
`46`	`46`	`if ( '*' === $selector->type_selector->ident \|\| strcasecmp( $breadcrumbs[0], $selector->type_selector->ident ) === 0 ) {`
`47`	`47`	`return $this->explore_matches( array_slice( $selectors, 2 ), array_slice( $breadcrumbs, 1 ) );`
`48`	`48`	`}`
`49`		`- return $this->explore_matches( $selectors, array_slice( $breadcrumbs, 1 ) );`
	`49`	`+ return false;`
`50`	`50`
`51`	`51`	`case self::COMBINATOR_DESCENDANT:`
`52`	`52`	`// Find _all_ the breadcrumbs that match and recurse from each of them.`