Issue with coach core when using alongside sitespeed

[Sarthakgp]

Your question

So I have ubuntu 24 docker image and I am installing sitespeed in it. Few months ago the build were being built properly however when I tried today I faced below issue

tries to install @sitespeed.io/edgedriver which fails when I do a cloud build
To resolve this I did below change
RUN bash -c ". $NVM_DIR/nvm.sh && nvm use 20 && cd /tmp/coach-core && npm install --production --no-optional--loglevel verbose"
After this I faced below issue

mkdirp/terser missing because coach-core runs its prepare script (which requires devDependencies).
To resolve this I changed the command to below
RUN bash -c ". $NVM_DIR/nvm.sh && nvm use 20 && cd /tmp/coach-core && npm install --omit=optional --loglevel verbose"
Which revolves me back to edgedriver error. Any help with this as I had not faced this issue before. Were any changes made in package.json

I basically install replace actual coachcore with the forked coach core repo. But I was able to do this successfully few months ago. @soulgalore any advice on this?

[soulgalore]

Hi @Sarthakgp Microsoft changed domain for Edgedriver some time ago, see #4535 (comment) . What sitespeed.io version are you using, if you bump to 38 or later that should have been fixed?

[Sarthakgp]

Hi @soulgalore thanks for the update. Even when I explicitely mention sitespeed 38 it gives same error. Is it due to me replacing coach core with my forked coach core? Just a hunch I am checking the link in my forked branch my guess is that might be the old one. I also found that the browsertime has been degraded "browsertime": "23.5.0", from 25.0.0

RUN bash -c ". $NVM_DIR/nvm.sh && nvm use 20 && npm install -g sitespeed.io@38 --omit=dev"

Update: even when I merged the updated branch in my forked one the issue still persists

# Replace bundled coach-core with custom version RUN bash -c '. $NVM_DIR/nvm.sh && \ nvm use 20 && \ SITESPEED_PATH=$(find "$NVM_DIR/versions/node/$(nvm current)/lib/node_modules" -type d -name sitespeed.io | head -n 1) && \ COACH_CORE_DIR="$SITESPEED_PATH/node_modules" && \ if [ -d "$COACH_CORE_DIR/coach-core" ]; then \ echo "Removing existing coach-core"; \ rm -rf "$COACH_CORE_DIR/coach-core"; \ else \ echo "No existing coach-core to remove"; \ fi && \ echo "Copying new coach-core to module directory"; \ mkdir -p "$COACH_CORE_DIR" && \ cp -r /tmp/coach-core "$COACH_CORE_DIR/coach-core"'

[Sarthakgp]

Okay I was able to resolve this using the EDGEDRIVER_SKIP_DOWNLOAD=true mentioned in unittest.yaml.

I included this in my dockerfile. Also merged latest code of coach-core in my forked one. Thanks @soulgalore