[clang-scan-deps] Avoid repeated map lookups (NFC) (llvm#127023)

kazutakahirata · sivan-shani · commit 9a2f4bb65bcd · 2025-02-21T15:41:53.000Z
diff --git a/clang/tools/clang-scan-deps/ClangScanDeps.cpp b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
@@ -308,8 +308,7 @@ class ResourceDirectoryCache {
       return "";
     StringRef Output = OutputBuf.get()->getBuffer().rtrim('\n');
 
-    Cache[ClangBinaryPath] = Output.str();
-    return Cache[ClangBinaryPath];
+    return Cache[ClangBinaryPath] = Output.str();
   }
 
 private:

Original file line number	Diff line number	Diff line change
`@@ -308,8 +308,7 @@ class ResourceDirectoryCache {`
`308`	`308`	`return "";`
`309`	`309`	`StringRef Output = OutputBuf.get()->getBuffer().rtrim('\n');`
`310`	`310`
`311`		`- Cache[ClangBinaryPath] = Output.str();`
`312`		`- return Cache[ClangBinaryPath];`
	`311`	`+ return Cache[ClangBinaryPath] = Output.str();`
`313`	`312`	`}`
`314`	`313`
`315`	`314`	`private:`