order_by(self, func=identity, descending=False)

[s-celles]

Hello,

I noticed

asq/asq/queryables.py

Line 609 in db0c4cb

def order_by(self, key_selector=identity):

and

asq/asq/parallel_queryable.py

Line 166 in db0c4cb

def order_by(self, func=identity):

I wonder if having descending keyword couldn't be a nice API improvement.

when descending is True, order_by_descending will be called.

What is your opinion?

Kind regards

[rob-smallshire]

What about an enum? order_by(order=ascending) or order_by(order=descending)

[s-celles]

enum or boolean. It is as you want. My idea was using boolean, as in reverse parameter of sorted function

sorted(iterable, /, *, key=None, reverse=False)

or in Pandas DataFrame.sort_values method with ascending parameter

DataFrame.sort_values(by, axis=0, ascending=True, inplace=False, kind='quicksort', na_position='last', ignore_index=False, key=None)[source]

[s-celles]

A boolean is simpler because it avoid having to import these enum values.
but I noticed in your code that you are using order (-1 or 1) which is an other possibility