Fix all clippy warning (dora-rs#1076)

Author: phil-opp

apis/c++/node/src/lib.rs

@@ -87,10 +87,6 @@ mod ffi {
     }
 }
 
-mod arrow_ffi {
-    pub use arrow::ffi::{FFI_ArrowArray, FFI_ArrowSchema};
-}
-
 #[cfg(feature = "ros2-bridge")]
 pub mod ros2 {
     pub use dora_ros2_bridge::*;
@@ -215,7 +211,7 @@ unsafe fn event_as_arrow_input(
             }
         }
         Err(e) => ffi::DoraResult {
-            error: format!("Error exporting Arrow array to C++: {:?}", e),
+            error: format!("Error exporting Arrow array to C++: {e:?}"),
         },
     }
 }
@@ -276,7 +272,7 @@ unsafe fn send_arrow_output(
             }
         }
         Err(e) => ffi::DoraResult {
-            error: format!("Error importing array from C++: {:?}", e),
+            error: format!("Error importing array from C++: {e:?}"),
         },
     }
 }

apis/python/node/src/lib.rs

@@ -320,6 +320,7 @@ impl Events {
     }
 }
 
+#[allow(clippy::large_enum_variant)]
 enum EventsInner {
     Dora(EventStream),
     Merged(Box<dyn Stream<Item = MergedEvent<PyObject>> + Unpin + Send + Sync>),

apis/python/operator/src/lib.rs

@@ -214,25 +214,13 @@ pub fn pydict_to_metadata(dict: Option<Bound<'_, PyDict>>) -> Result<MetadataPar
                 parameters.insert(key, Parameter::Float(value.extract::<f64>()?))
             } else if value.is_instance_of::<PyString>() {
                 parameters.insert(key, Parameter::String(value.extract()?))
-            } else if value.is_instance_of::<PyTuple>()
+            } else if (value.is_instance_of::<PyTuple>() || value.is_instance_of::<PyList>())
                 && value.len()? > 0
                 && value.get_item(0)?.is_exact_instance_of::<PyInt>()
             {
                 let list: Vec<i64> = value.extract()?;
                 parameters.insert(key, Parameter::ListInt(list))
-            } else if value.is_instance_of::<PyList>()
-                && value.len()? > 0
-                && value.get_item(0)?.is_exact_instance_of::<PyInt>()
-            {
-                let list: Vec<i64> = value.extract()?;
-                parameters.insert(key, Parameter::ListInt(list))
-            } else if value.is_instance_of::<PyTuple>()
-                && value.len()? > 0
-                && value.get_item(0)?.is_exact_instance_of::<PyFloat>()
-            {
-                let list: Vec<f64> = value.extract()?;
-                parameters.insert(key, Parameter::ListFloat(list))
-            } else if value.is_instance_of::<PyList>()
+            } else if (value.is_instance_of::<PyTuple>() || value.is_instance_of::<PyList>())
                 && value.len()? > 0
                 && value.get_item(0)?.is_exact_instance_of::<PyFloat>()
             {

apis/rust/node/src/event_stream/merged.rs

@@ -8,6 +8,7 @@ use futures_concurrency::stream::Merge;
 
 /// A Dora event or an event from an external source.
 #[derive(Debug)]
+#[allow(clippy::large_enum_variant)]
 pub enum MergedEvent<E> {
     /// A Dora event
     Dora(super::Event),

binaries/cli/src/command/self_.rs

@@ -55,25 +55,24 @@ impl Executable for SelfSubCommand {
                                 );
                             } else {
                                 println!(
-                                    "Dora CLI is already at the latest version: {}",
-                                    current_version
+                                    "Dora CLI is already at the latest version: {current_version}"
                                 );
                             }
                         }
-                        Err(e) => println!("Failed to check for updates: {}", e),
+                        Err(e) => println!("Failed to check for updates: {e}"),
                     }
                 } else {
                     // Perform the actual update
                     match status.update() {
                         Ok(update_status) => match update_status {
                             self_update::Status::UpToDate(version) => {
-                                println!("Dora CLI is already at the latest version: {}", version);
+                                println!("Dora CLI is already at the latest version: {version}");
                             }
                             self_update::Status::Updated(version) => {
-                                println!("Successfully updated Dora CLI to version: {}", version);
+                                println!("Successfully updated Dora CLI to version: {version}");
                             }
                         },
-                        Err(e) => println!("Failed to update: {}", e),
+                        Err(e) => println!("Failed to update: {e}"),
                     }
                 }
             }

binaries/daemon/src/lib.rs

@@ -1070,7 +1070,7 @@ impl Daemon {
             for task in tasks {
                 let NodeBuildTask {
                     node_id,
-                    dynamic_node,
+                    dynamic_node: _,
                     task,
                 } = task;
                 let node = task
@@ -2680,6 +2680,7 @@ impl Event {
 }
 
 #[derive(Debug)]
+#[allow(clippy::large_enum_variant)]
 pub enum DaemonNodeEvent {
     OutputsDone {
         reply_sender: oneshot::Sender<DaemonReply>,

binaries/daemon/src/log.rs

@@ -416,7 +416,7 @@ struct Indent<'a>(&'a str);
 impl std::fmt::Display for Indent<'_> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         for line in self.0.lines() {
-            write!(f, "   {}", line)?;
+            write!(f, "   {line}")?;
         }
         Ok(())
     }

binaries/daemon/src/node_communication/mod.rs

@@ -152,7 +152,7 @@ pub async fn spawn_listener_loop(
             if !tmpfile_dir.exists() {
                 std::fs::create_dir_all(&tmpfile_dir).context("could not create tmp dir")?;
             }
-            let socket_file = tmpfile_dir.join(format!("{}.sock", node_id));
+            let socket_file = tmpfile_dir.join(format!("{node_id}.sock"));
             let socket = match UnixListener::bind(&socket_file) {
                 Ok(socket) => socket,
                 Err(err) => {

binaries/daemon/src/node_communication/shmem.rs

@@ -42,6 +42,7 @@ pub async fn listener_loop(
     Listener::run(connection, daemon_tx, clock).await
 }
 
+#[allow(clippy::large_enum_variant)]
 enum Operation {
     Receive(oneshot::Sender<eyre::Result<Option<Timestamped<DaemonRequest>>>>),
     Send {

binaries/daemon/src/spawn.rs

@@ -633,7 +633,7 @@ async fn path_spawn_command(
                     .wrap_err("failed to download custom node")?
             } else {
                 resolve_path(source, working_dir)
-                    .wrap_err_with(|| format!("failed to resolve node source `{}`", source))?
+                    .wrap_err_with(|| format!("failed to resolve node source `{source}`"))?
             };
 
             // If extension is .py, use python to run the script