#568 Add support for SQLite (not yet complete, but getting close)

sjh37 · sjh37 · commit c1c1017071da · 2023-03-27T22:13:00.000+01:00
diff --git a/EntityFramework.Reverse.POCO.Generator/EF.Reverse.POCO.v3.ttinclude b/EntityFramework.Reverse.POCO.Generator/EF.Reverse.POCO.v3.ttinclude
@@ -14719,12 +14719,11 @@ SELECT 'main' AS SchemaName,
        ColumnName,
        IsNullable,
        REPLACE(type, '(' || length || ')', '') AS TypeName,
-       type as XXXXX,
        CASE WHEN INSTR(type, ',') > 0 THEN 0 ELSE length END AS [MaxLength],
-       CASE WHEN INSTR(type, ',') > 0 THEN SUBSTR(type, INSTR(type, ',') - 1) ELSE 0 END AS Precision,
+       Precision,
        dflt_value AS [Default],
        0 AS DateTimePrecision,
-       CASE WHEN INSTR(type, ',') > 0 THEN SUBSTR(type, 1, INSTR(type, ',') - 1) ELSE 0 END AS Scale,
+       Scale,
        pk AS IsIdentity,
        0 AS IsRowGuid,
        0 AS IsComputed,
@@ -14741,7 +14740,9 @@ FROM (SELECT m.tbl_name,
              1 - c.""notnull"" AS IsNullable,
              c.dflt_value,
              c.pk,
-             SUBSTR(c.type, INSTR(c.type, '(') + 1, INSTR(c.type, ')') - INSTR(c.type, '(') - 1) AS length
+             SUBSTR(c.type, INSTR(c.type, '(') + 1, INSTR(c.type, ')') - INSTR(c.type, '(') - 1) AS length,
+             CAST(SUBSTR(c.type, INSTR(c.type, '(') + 1, INSTR(c.type, ',') - INSTR(c.type, '(') - 1) AS INTEGER) AS Precision,
+             CAST(SUBSTR(c.type, INSTR(c.type, ',') + 1, INSTR(c.type, ')') - INSTR(c.type, ',') - 1) AS INTEGER) AS Scale
       FROM sqlite_master m
                JOIN PRAGMA_TABLE_INFO(m.name) c
       WHERE m.type IN ('table', 'view')
@@ -14752,67 +14753,26 @@ ORDER BY tbl_name, cid;";
         protected override string ForeignKeySQL()
         {
             return @"
-SELECT  fkData.FK_Table,
-        fkData.FK_Column,
-        fkData.PK_Table,
-        fkData.PK_Column,
-        fkData.Constraint_Name,
-        fkData.fkSchema,
-        fkData.pkSchema,
-        fkData.primarykey,
-        fkData.ORDINAL_POSITION,
-        fkData.CascadeOnDelete,
-        fkData.IsNotEnforced
-FROM    (SELECT FK.name AS FK_Table,
-                FkCol.name AS FK_Column,
-                PK.name AS PK_Table,
-                PkCol.name AS PK_Column,
-                OBJECT_NAME(f.object_id) AS Constraint_Name,
-                SCHEMA_NAME(FK.schema_id) AS fkSchema,
-                SCHEMA_NAME(PK.schema_id) AS pkSchema,
-                PkCol.name AS primarykey,
-                k.constraint_column_id AS ORDINAL_POSITION,
-                CASE WHEN f.delete_referential_action = 1 THEN 1
-                     ELSE 0
-                END AS CascadeOnDelete,
-                f.is_disabled AS IsNotEnforced,
-                ROW_NUMBER() OVER (PARTITION BY FK.name, FkCol.name, PK.name, PkCol.name, SCHEMA_NAME(FK.schema_id), SCHEMA_NAME(PK.schema_id) ORDER BY f.object_id) AS n
-         FROM   sys.objects AS PK
-                INNER JOIN sys.foreign_keys AS f
-                    INNER JOIN sys.foreign_key_columns AS k
-                        ON k.constraint_object_id = f.object_id
-                    INNER JOIN sys.indexes AS i
-                        ON f.referenced_object_id = i.object_id
-                           AND f.key_index_id = i.index_id
-                    ON PK.object_id = f.referenced_object_id
-                INNER JOIN sys.objects AS FK
-                    ON f.parent_object_id = FK.object_id
-                INNER JOIN sys.columns AS PkCol
-                    ON f.referenced_object_id = PkCol.object_id
-                       AND k.referenced_column_id = PkCol.column_id
-                INNER JOIN sys.columns AS FkCol
-                    ON f.parent_object_id = FkCol.object_id
-                       AND k.parent_column_id = FkCol.column_id) fkData
-WHERE   fkData.n = 1 -- Remove duplicate foreign keys";
+SELECT m.name AS FK_Table,
+       p.[from] AS FK_Column,
+       p.[table] AS PK_Table,
+       p.[to] AS PK_Column,
+       'FK_' || TRIM(m.name) || '_' || TRIM(p.[to]) as Constraint_Name,
+       'main' as fkSchema,
+       'main' as pkSchema,
+       p.[to] AS primarykey,
+       p.id + 1 as ORDINAL_POSITION,
+       case when P.on_delete is 'CASCADE' then 1 else 0 end as CascadeOnDelete,
+       0 as IsNotEnforced
+FROM sqlite_master m
+         JOIN PRAGMA_FOREIGN_KEY_LIST(m.name) p ON m.name != p.[table]
+WHERE m.type = 'table'
+ORDER BY m.name;";
         }
 
         protected override string ExtendedPropertySQL()
         {
-            return @"
-SELECT  s.name AS [schema],
-    t.name AS [table],
-    c.name AS [column],
-    value AS [property]
-FROM    sys.extended_properties AS ep
-    INNER JOIN sys.tables AS t
-        ON ep.major_id = t.object_id
-    INNER JOIN sys.schemas AS s
-        ON s.schema_id = t.schema_id
-    LEFT JOIN sys.columns AS c
-        ON ep.major_id = c.object_id
-            AND ep.minor_id = c.column_id
-WHERE   class = 1
-ORDER BY t.name";
+            return string.Empty;
         }
 
         protected override string DoesExtendedPropertyTableExistSQL()
@@ -14823,34 +14783,44 @@ ORDER BY t.name";
         protected override string IndexSQL()
         {
             return @"
-SELECT  SCHEMA_NAME(t.schema_id) AS TableSchema,
-    t.name AS TableName,
-    ind.name AS IndexName,
-    ic.key_ordinal AS KeyOrdinal,
-    col.name AS ColumnName,
-    ind.is_unique AS IsUnique,
-    ind.is_primary_key AS IsPrimaryKey,
-    ind.is_unique_constraint AS IsUniqueConstraint,
-    CASE WHEN ind.[type] = 1 AND ind.is_primary_key = 1 THEN 1 ELSE 0 END AS IsClustered,
-    (
-        SELECT COUNT(1)
-        FROM   sys.index_columns i
-        WHERE  i.object_id = ind.object_id
-            AND i.index_id = ind.index_id
-    ) AS ColumnCount
-FROM    sys.tables t
-    INNER JOIN sys.indexes ind
-        ON ind.object_id = t.object_id
-    INNER JOIN sys.index_columns ic
-        ON ind.object_id = ic.object_id
-            AND ind.index_id = ic.index_id
-    INNER JOIN sys.columns col
-        ON ic.object_id = col.object_id
-            AND ic.column_id = col.column_id
-WHERE   t.is_ms_shipped = 0
-    AND ind.ignore_dup_key = 0
-    AND ic.key_ordinal > 0
-    AND t.name NOT LIKE 'sysdiagram%'";
+WITH split(TableName, IndexName, KeyOrdinal, ColumnName, csv) AS (
+  SELECT TableName,
+         IndexName,
+         KeyOrdinal,
+         '',
+         column_name || ','
+  FROM (SELECT TableName,
+               IndexName,
+               0 AS KeyOrdinal,
+               SUBSTR(sql, INSTR(sql, '(') + 1, INSTR(sql, ')') - INSTR(sql, '(') - 1) AS column_name
+        FROM (SELECT tbl_name AS TableName,
+                     name AS IndexName,
+                     REPLACE(REPLACE(sql, ']', ''), '[', '') AS sql
+              FROM sqlite_master
+              WHERE type = 'index'
+                AND name NOT LIKE 'sqlite_%'))
+  UNION ALL
+  SELECT TableName,
+         IndexName,
+         KeyOrdinal + 1,
+         SUBSTR(csv, 0, INSTR(csv, ',')),
+         SUBSTR(csv, INSTR(csv, ',') + 1)
+  FROM split
+  WHERE csv != '')
+SELECT 'main' AS TableSchema,
+       s.TableName,
+       s.IndexName,
+       s.KeyOrdinal,
+       TRIM(s.ColumnName),
+       0 AS IsUnique,
+       0 AS IsPrimaryKey,
+       0 AS IsUniqueConstraint,
+       (SELECT MAX(KeyOrdinal)
+        FROM split x
+        WHERE x.TableName = s.TableName
+          AND x.IndexName = s.IndexName) AS ColumnCount
+FROM split s
+WHERE ColumnName != ''";
         }
 
         public override bool CanReadStoredProcedures()
@@ -14888,27 +14858,14 @@ SELECT * FROM MultiContext.ForeignKey;";
         protected override string TriggerSQL()
         {
             return @"
-SELECT S.name SchemaName, O.name TableName, T.name TriggerName
-FROM sys.triggers T
-    LEFT JOIN sys.all_objects O
-        ON T.parent_id = O.object_id
-    LEFT JOIN sys.schemas S
-        ON S.schema_id = O.schema_id
-WHERE T.type = 'TR'
-      AND T.is_disabled = 0
-      AND S.name IS NOT NULL
-      AND O.name IS NOT NULL
-ORDER BY SchemaName, TableName, TriggerName;";
+SELECT 'main' AS TableSchema, tbl_name as TableName, name as TriggerName
+FROM sqlite_master
+WHERE type = 'trigger';";
         }
 
         protected override string[] MemoryOptimisedSQL()
         {
-            return new string[]
-            {
-                "SELECT compatibility_level FROM sys.databases WHERE name = DB_NAME();",
-                "SELECT CAST(SERVERPROPERTY(N'IsXTPSupported') AS BIT) AS IsXTPSupported;",
-                "SELECT SCHEMA_NAME(schema_id) SchemaName, name TableName FROM sys.tables WHERE is_memory_optimized = 1;"
-            };
+            return null;
         }
 
         protected override string SynonymTableSQLSetup()
@@ -14943,27 +14900,7 @@ ORDER BY SchemaName, TableName, TriggerName;";
 
         protected override string DefaultSchema(DbConnection conn)
         {
-            try
-            {
-                var cmd = GetCmd(conn);
-                if (cmd != null)
-                {
-                    cmd.CommandText = "SELECT SCHEMA_NAME()";
-                    using (var rdr = cmd.ExecuteReader())
-                    {
-                        if (rdr.Read())
-                        {
-                            return rdr[0].ToString();
-                        }
-                    }
-                }
-            }
-            catch
-            {
-                // Ignored
-            }
-
-            return "dbo";
+            return "main";
         }
 
         protected override string SpecialQueryFlags()
diff --git a/Generator.Tests.Integration/SingleDatabaseTestSQLite.cs b/Generator.Tests.Integration/SingleDatabaseTestSQLite.cs
@@ -30,29 +30,81 @@ public SingleDatabaseTestSQLite()
             var cmd = _masterConnection.CreateCommand();
             cmd.CommandText =
                 @"
+PRAGMA foreign_keys = ON;
+
 CREATE TABLE Efrpg
 (
-    Id    INTEGER PRIMARY KEY,
-    vc    varchar(12)  NULL,
-    nvc   nvarchar(12) NULL,
-    int1  INTEGER  DEFAULT 123,
-    real1 REAL,
-    text1 TEXT,
-    text2 TEXT(20) DEFAULT 'Hello',
-    blob1 BLOB,
-    blob2 BLOB(37),
-    num1  NUMERIC,
-    num2  NUMERIC(10, 5)
+    Id     INTEGER,
+
+    text1  TEXT,
+    text2  CHARACTER(22),
+    text3  VARCHAR(33),
+    text4  VARYING CHARACTER(44),
+    text5  NCHAR(55),
+    text6  NATIVE CHARACTER(66),
+    text7  NVARCHAR(77),
+    text8  TEXT(88) DEFAULT 'Hello',
+    text9  CLOB,
+
+    int1   INTEGER  DEFAULT 123,
+    int2   INT UNIQUE,
+    int3   SMALLINT,
+    int4   MEDIUMINT,
+    int5   BIGINT,
+    int6   UNSIGNED BIG INT,
+    int7   INT2,
+    INT8   INT8,
+
+    blob1  BLOB,
+    blob2  BLOB(22),
+
+    real1  REAL CHECK (real1 > 123),
+    real2  DOUBLE,
+    real3  DOUBLE PRECISION,
+    real4  FLOAT,
+
+    num1   NUMERIC,
+    num2   DECIMAL(10, 5),
+    num22  DECIMAL(10, 5),
+    num222 DECIMAL(10, 5),
+    num3   BOOLEAN,
+    num4   DATE,
+    num5   DATETIME,
+
+    CONSTRAINT [PK_Efrpg] PRIMARY KEY (Id)
 );
+
 CREATE TABLE EfrpgItems
 (
     Id        INTEGER PRIMARY KEY,
     EfrpgId   INTEGER NOT NULL,
+    Test      INT     NOT NULL,
     CreatedAt DATETIME DEFAULT CURRENT_TIMESTAMP,
-    FOREIGN KEY (EfrpgId) REFERENCES 'Efrpg' (Id)
-        ON DELETE NO ACTION ON UPDATE NO ACTION
+    FOREIGN KEY (EfrpgId) REFERENCES [Efrpg] (Id)
+        ON DELETE CASCADE ON UPDATE NO ACTION
 );
-CREATE INDEX [IX_Efrpg_vc] ON [Efrpg] ([vc]);";
+
+CREATE INDEX [IX_Efrpg] ON [Efrpg] ([TEXT3]);
+CREATE INDEX [IX_Efrpg_Composite] ON [Efrpg] (int1, int2);
+
+CREATE VIEW ThisIsAView AS
+SELECT Id, text1, int1, blob1, real1, num1
+FROM Efrpg;
+
+CREATE TRIGGER efrpg_trigger
+    AFTER INSERT
+    ON Efrpg
+BEGIN
+    SELECT 'Test';
+END;
+
+INSERT INTO Efrpg (Id, int1, int2)
+VALUES (1, 2, 3),
+       (2, 3, 4);
+INSERT INTO EfrpgItems (Id, EfrpgId, Test)
+VALUES (1, 1, 3),
+       (2, 2, 4);
+";
             cmd.ExecuteNonQuery();
         }
 
diff --git a/Generator/Readers/SQLiteDatabaseReader.cs b/Generator/Readers/SQLiteDatabaseReader.cs
